RE: [PATCH 1/2] lib/string_helpers: Introduce strsplit_u32()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "'Cezary Rojewski'" <cezary.rojewski@xxxxxxxxx>, Andy Shevchenko <andy.shevchenko@xxxxxxxxx>, Péter Ujfalusi <peter.ujfalusi@xxxxxxxxxxxxxxx>
Subject: RE: [PATCH 1/2] lib/string_helpers: Introduce strsplit_u32()
From: David Laight <David.Laight@xxxxxxxxxx>
Date: Wed, 13 Jul 2022 09:14:09 +0000
Cc: Andy Shevchenko <andy@xxxxxxxxxx>, Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>, ALSA Development Mailing List <alsa-devel@xxxxxxxxxxxxxxxx>, Kai Vehmanen <kai.vehmanen@xxxxxxxxxxxxxxx>, Liam Girdwood <lgirdwood@xxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Takashi Iwai <tiwai@xxxxxxxx>, Hans de Goede <hdegoede@xxxxxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>, Ranjani Sridharan <ranjani.sridharan@xxxxxxxxxxxxxxx>, "amadeuszx.slawinski@xxxxxxxxxxxxxxx" <amadeuszx.slawinski@xxxxxxxxxxxxxxx>, Bard Liao <yung-chuan.liao@xxxxxxxxxxxxxxx>
In-reply-to: <e2fe6351-f9ee-48eb-ad7f-280249f7f3f7@intel.com>
References: <20220707091301.1282291-1-cezary.rojewski@intel.com> <CAHp75VceKBoxXVPP4dRYb8LQqHMMDHFp6-E2iuZ-h2RTK8PWQQ@mail.gmail.com> <e0c7d254-ace3-625c-cc83-52ca0b45e9fc@intel.com> <CAHp75VckU2ZraLJ-frjWXjUu9pFW+-XmWgTbYqUXOUNAD-1HGA@mail.gmail.com> <6c8e4104-2239-a188-649d-585f059cabdd@intel.com> <YsgjdKEtE7pMDTnZ@smile.fi.intel.com> <a73b3ec0-5abb-ddfd-414b-b9807f05413e@linux.intel.com> <CAHp75Vd4D0KF7ik+aMOwv-+bofWja_tDe4YUmihQBF+RiHZTmA@mail.gmail.com> <e2fe6351-f9ee-48eb-ad7f-280249f7f3f7@intel.com>

>          if (pint)
> -               *pint = value;
> +               memcpy(pint, &value, min(nsize, sizeof(value)));

That is just soooooo broken.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)

Follow-Ups:
- Re: [PATCH 1/2] lib/string_helpers: Introduce strsplit_u32()
  - From: Andy Shevchenko

References:
- [PATCH 1/2] lib/string_helpers: Introduce strsplit_u32()
  - From: Cezary Rojewski
- Re: [PATCH 1/2] lib/string_helpers: Introduce strsplit_u32()
  - From: Andy Shevchenko
- Re: [PATCH 1/2] lib/string_helpers: Introduce strsplit_u32()
  - From: Cezary Rojewski
- Re: [PATCH 1/2] lib/string_helpers: Introduce strsplit_u32()
  - From: Andy Shevchenko
- Re: [PATCH 1/2] lib/string_helpers: Introduce strsplit_u32()
  - From: Cezary Rojewski
- Re: [PATCH 1/2] lib/string_helpers: Introduce strsplit_u32()
  - From: Andy Shevchenko
- Re: [PATCH 1/2] lib/string_helpers: Introduce strsplit_u32()
  - From: Péter Ujfalusi
- Re: [PATCH 1/2] lib/string_helpers: Introduce strsplit_u32()
  - From: Andy Shevchenko
- Re: [PATCH 1/2] lib/string_helpers: Introduce strsplit_u32()
  - From: Cezary Rojewski

Prev by Date: [PATCH] ASoc: audio-graph-card2: Fix refcount leak bug in __graph_get_type()
Next by Date: Re: [PATCH 1/2] lib/string_helpers: Introduce strsplit_u32()
Previous by thread: Re: [PATCH 1/2] lib/string_helpers: Introduce strsplit_u32()
Next by thread: Re: [PATCH 1/2] lib/string_helpers: Introduce strsplit_u32()
Index(es):
- Date
- Thread

[Index of Archives] [ALSA User] [Linux Audio Users] [Pulse Audio] [Kernel Archive] [Asterisk PBX] [Photo Sharing] [Linux Sound] [Video 4 Linux] [Gimp] [Yosemite News]