Hi Andy, I love your patch! Yet something to improve: [auto build test ERROR on tiwai-sound/for-next] [also build test ERROR on linus/master v5.19-rc6 next-20220711] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/ALSA-hda-cs35l41-Improve-dev_err_probe-messaging/20220711-175606 base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next config: mips-allyesconfig (https://download.01.org/0day-ci/archive/20220712/202207121250.pG2NiH2y-lkp@xxxxxxxxx/config) compiler: mips-linux-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/1822f133c760384365a12621de82e3a96e061ecf git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Andy-Shevchenko/ALSA-hda-cs35l41-Improve-dev_err_probe-messaging/20220711-175606 git checkout 1822f133c760384365a12621de82e3a96e061ecf # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): sound/pci/hda/cs35l41_hda.c: In function 'cs35l41_hda_read_acpi': >> sound/pci/hda/cs35l41_hda.c:350:59: error: invalid use of undefined type 'struct acpi_device' 350 | cs35l41->reset_gpio = fwnode_gpiod_get_index(&adev->fwnode, "reset", cs35l41->index, | ^~ vim +350 sound/pci/hda/cs35l41_hda.c 7b2f3eb492dac76 Lucas Tanure 2021-12-17 299 f7f207375d4e6eb Lucas Tanure 2022-04-13 300 static int cs35l41_hda_read_acpi(struct cs35l41_hda *cs35l41, const char *hid, int id) 7b2f3eb492dac76 Lucas Tanure 2021-12-17 301 { f7f207375d4e6eb Lucas Tanure 2022-04-13 302 struct cs35l41_hw_cfg *hw_cfg = &cs35l41->hw_cfg; 7b2f3eb492dac76 Lucas Tanure 2021-12-17 303 u32 values[HDA_MAX_COMPONENTS]; 7b2f3eb492dac76 Lucas Tanure 2021-12-17 304 struct acpi_device *adev; 8c286a0f973a812 Lucas Tanure 2022-01-17 305 struct device *physdev; 7b2f3eb492dac76 Lucas Tanure 2021-12-17 306 char *property; 7b2f3eb492dac76 Lucas Tanure 2021-12-17 307 size_t nval; 7b2f3eb492dac76 Lucas Tanure 2021-12-17 308 int i, ret; 7b2f3eb492dac76 Lucas Tanure 2021-12-17 309 7b2f3eb492dac76 Lucas Tanure 2021-12-17 310 adev = acpi_dev_get_first_match_dev(hid, NULL, -1); 7b2f3eb492dac76 Lucas Tanure 2021-12-17 311 if (!adev) { 7b2f3eb492dac76 Lucas Tanure 2021-12-17 312 dev_err(cs35l41->dev, "Failed to find an ACPI device for %s\n", hid); f7f207375d4e6eb Lucas Tanure 2022-04-13 313 return -ENODEV; 7b2f3eb492dac76 Lucas Tanure 2021-12-17 314 } 7b2f3eb492dac76 Lucas Tanure 2021-12-17 315 8c286a0f973a812 Lucas Tanure 2022-01-17 316 physdev = get_device(acpi_get_first_physical_node(adev)); 7b2f3eb492dac76 Lucas Tanure 2021-12-17 317 acpi_dev_put(adev); 7b2f3eb492dac76 Lucas Tanure 2021-12-17 318 7b2f3eb492dac76 Lucas Tanure 2021-12-17 319 property = "cirrus,dev-index"; 8c286a0f973a812 Lucas Tanure 2022-01-17 320 ret = device_property_count_u32(physdev, property); 7b2f3eb492dac76 Lucas Tanure 2021-12-17 321 if (ret <= 0) 7b2f3eb492dac76 Lucas Tanure 2021-12-17 322 goto no_acpi_dsd; 7b2f3eb492dac76 Lucas Tanure 2021-12-17 323 7b2f3eb492dac76 Lucas Tanure 2021-12-17 324 if (ret > ARRAY_SIZE(values)) { 7b2f3eb492dac76 Lucas Tanure 2021-12-17 325 ret = -EINVAL; 7b2f3eb492dac76 Lucas Tanure 2021-12-17 326 goto err; 7b2f3eb492dac76 Lucas Tanure 2021-12-17 327 } 7b2f3eb492dac76 Lucas Tanure 2021-12-17 328 nval = ret; 7b2f3eb492dac76 Lucas Tanure 2021-12-17 329 8c286a0f973a812 Lucas Tanure 2022-01-17 330 ret = device_property_read_u32_array(physdev, property, values, nval); 7b2f3eb492dac76 Lucas Tanure 2021-12-17 331 if (ret) 7b2f3eb492dac76 Lucas Tanure 2021-12-17 332 goto err; 7b2f3eb492dac76 Lucas Tanure 2021-12-17 333 7b2f3eb492dac76 Lucas Tanure 2021-12-17 334 cs35l41->index = -1; 7b2f3eb492dac76 Lucas Tanure 2021-12-17 335 for (i = 0; i < nval; i++) { 7b2f3eb492dac76 Lucas Tanure 2021-12-17 336 if (values[i] == id) { 7b2f3eb492dac76 Lucas Tanure 2021-12-17 337 cs35l41->index = i; 7b2f3eb492dac76 Lucas Tanure 2021-12-17 338 break; 7b2f3eb492dac76 Lucas Tanure 2021-12-17 339 } 7b2f3eb492dac76 Lucas Tanure 2021-12-17 340 } 7b2f3eb492dac76 Lucas Tanure 2021-12-17 341 if (cs35l41->index == -1) { 7b2f3eb492dac76 Lucas Tanure 2021-12-17 342 dev_err(cs35l41->dev, "No index found in %s\n", property); 7b2f3eb492dac76 Lucas Tanure 2021-12-17 343 ret = -ENODEV; 7b2f3eb492dac76 Lucas Tanure 2021-12-17 344 goto err; 7b2f3eb492dac76 Lucas Tanure 2021-12-17 345 } 7b2f3eb492dac76 Lucas Tanure 2021-12-17 346 8c286a0f973a812 Lucas Tanure 2022-01-17 347 /* To use the same release code for all laptop variants we can't use devm_ version of 8c286a0f973a812 Lucas Tanure 2022-01-17 348 * gpiod_get here, as CLSA010* don't have a fully functional bios with an _DSD node 8c286a0f973a812 Lucas Tanure 2022-01-17 349 */ 7b2f3eb492dac76 Lucas Tanure 2021-12-17 @350 cs35l41->reset_gpio = fwnode_gpiod_get_index(&adev->fwnode, "reset", cs35l41->index, 7b2f3eb492dac76 Lucas Tanure 2021-12-17 351 GPIOD_OUT_LOW, "cs35l41-reset"); 7b2f3eb492dac76 Lucas Tanure 2021-12-17 352 7b2f3eb492dac76 Lucas Tanure 2021-12-17 353 property = "cirrus,speaker-position"; 8c286a0f973a812 Lucas Tanure 2022-01-17 354 ret = device_property_read_u32_array(physdev, property, values, nval); 7b2f3eb492dac76 Lucas Tanure 2021-12-17 355 if (ret) f7f207375d4e6eb Lucas Tanure 2022-04-13 356 goto err; 7b2f3eb492dac76 Lucas Tanure 2021-12-17 357 hw_cfg->spk_pos = values[cs35l41->index]; 7b2f3eb492dac76 Lucas Tanure 2021-12-17 358 00f87ec74c3c096 Stefan Binding 2022-05-09 359 cs35l41->channel_index = 0; 00f87ec74c3c096 Stefan Binding 2022-05-09 360 for (i = 0; i < cs35l41->index; i++) 00f87ec74c3c096 Stefan Binding 2022-05-09 361 if (values[i] == hw_cfg->spk_pos) 00f87ec74c3c096 Stefan Binding 2022-05-09 362 cs35l41->channel_index++; 00f87ec74c3c096 Stefan Binding 2022-05-09 363 7b2f3eb492dac76 Lucas Tanure 2021-12-17 364 property = "cirrus,gpio1-func"; 8c286a0f973a812 Lucas Tanure 2022-01-17 365 ret = device_property_read_u32_array(physdev, property, values, nval); 7b2f3eb492dac76 Lucas Tanure 2021-12-17 366 if (ret) f7f207375d4e6eb Lucas Tanure 2022-04-13 367 goto err; f7f207375d4e6eb Lucas Tanure 2022-04-13 368 hw_cfg->gpio1.func = values[cs35l41->index]; 2603c974b45dbfe Lucas Tanure 2022-04-13 369 hw_cfg->gpio1.valid = true; 7b2f3eb492dac76 Lucas Tanure 2021-12-17 370 7b2f3eb492dac76 Lucas Tanure 2021-12-17 371 property = "cirrus,gpio2-func"; 8c286a0f973a812 Lucas Tanure 2022-01-17 372 ret = device_property_read_u32_array(physdev, property, values, nval); 7b2f3eb492dac76 Lucas Tanure 2021-12-17 373 if (ret) f7f207375d4e6eb Lucas Tanure 2022-04-13 374 goto err; f7f207375d4e6eb Lucas Tanure 2022-04-13 375 hw_cfg->gpio2.func = values[cs35l41->index]; 2603c974b45dbfe Lucas Tanure 2022-04-13 376 hw_cfg->gpio2.valid = true; 7b2f3eb492dac76 Lucas Tanure 2021-12-17 377 7b2f3eb492dac76 Lucas Tanure 2021-12-17 378 property = "cirrus,boost-peak-milliamp"; 8c286a0f973a812 Lucas Tanure 2022-01-17 379 ret = device_property_read_u32_array(physdev, property, values, nval); 7b2f3eb492dac76 Lucas Tanure 2021-12-17 380 if (ret == 0) 7b2f3eb492dac76 Lucas Tanure 2021-12-17 381 hw_cfg->bst_ipk = values[cs35l41->index]; 2603c974b45dbfe Lucas Tanure 2022-04-13 382 else 2603c974b45dbfe Lucas Tanure 2022-04-13 383 hw_cfg->bst_ipk = -1; 7b2f3eb492dac76 Lucas Tanure 2021-12-17 384 7b2f3eb492dac76 Lucas Tanure 2021-12-17 385 property = "cirrus,boost-ind-nanohenry"; 8c286a0f973a812 Lucas Tanure 2022-01-17 386 ret = device_property_read_u32_array(physdev, property, values, nval); 7b2f3eb492dac76 Lucas Tanure 2021-12-17 387 if (ret == 0) 7b2f3eb492dac76 Lucas Tanure 2021-12-17 388 hw_cfg->bst_ind = values[cs35l41->index]; 2603c974b45dbfe Lucas Tanure 2022-04-13 389 else 2603c974b45dbfe Lucas Tanure 2022-04-13 390 hw_cfg->bst_ind = -1; 7b2f3eb492dac76 Lucas Tanure 2021-12-17 391 7b2f3eb492dac76 Lucas Tanure 2021-12-17 392 property = "cirrus,boost-cap-microfarad"; 8c286a0f973a812 Lucas Tanure 2022-01-17 393 ret = device_property_read_u32_array(physdev, property, values, nval); 7b2f3eb492dac76 Lucas Tanure 2021-12-17 394 if (ret == 0) 7b2f3eb492dac76 Lucas Tanure 2021-12-17 395 hw_cfg->bst_cap = values[cs35l41->index]; 2603c974b45dbfe Lucas Tanure 2022-04-13 396 else 2603c974b45dbfe Lucas Tanure 2022-04-13 397 hw_cfg->bst_cap = -1; 7b2f3eb492dac76 Lucas Tanure 2021-12-17 398 b8388a1aba32bef Lucas Tanure 2022-04-13 399 if (hw_cfg->bst_ind > 0 || hw_cfg->bst_cap > 0 || hw_cfg->bst_ipk > 0) b8388a1aba32bef Lucas Tanure 2022-04-13 400 hw_cfg->bst_type = CS35L41_INT_BOOST; b8388a1aba32bef Lucas Tanure 2022-04-13 401 else b8388a1aba32bef Lucas Tanure 2022-04-13 402 hw_cfg->bst_type = CS35L41_EXT_BOOST; b8388a1aba32bef Lucas Tanure 2022-04-13 403 2603c974b45dbfe Lucas Tanure 2022-04-13 404 hw_cfg->valid = true; 8c286a0f973a812 Lucas Tanure 2022-01-17 405 put_device(physdev); 7b2f3eb492dac76 Lucas Tanure 2021-12-17 406 f7f207375d4e6eb Lucas Tanure 2022-04-13 407 return 0; 7b2f3eb492dac76 Lucas Tanure 2021-12-17 408 7b2f3eb492dac76 Lucas Tanure 2021-12-17 409 err: 8c286a0f973a812 Lucas Tanure 2022-01-17 410 put_device(physdev); 7b2f3eb492dac76 Lucas Tanure 2021-12-17 411 dev_err(cs35l41->dev, "Failed property %s: %d\n", property, ret); 7b2f3eb492dac76 Lucas Tanure 2021-12-17 412 f7f207375d4e6eb Lucas Tanure 2022-04-13 413 return ret; 7b2f3eb492dac76 Lucas Tanure 2021-12-17 414 7b2f3eb492dac76 Lucas Tanure 2021-12-17 415 no_acpi_dsd: 7b2f3eb492dac76 Lucas Tanure 2021-12-17 416 /* 7b2f3eb492dac76 Lucas Tanure 2021-12-17 417 * Device CLSA0100 doesn't have _DSD so a gpiod_get by the label reset won't work. 7b2f3eb492dac76 Lucas Tanure 2021-12-17 418 * And devices created by i2c-multi-instantiate don't have their device struct pointing to 8c286a0f973a812 Lucas Tanure 2022-01-17 419 * the correct fwnode, so acpi_dev must be used here. 7b2f3eb492dac76 Lucas Tanure 2021-12-17 420 * And devm functions expect that the device requesting the resource has the correct 8c286a0f973a812 Lucas Tanure 2022-01-17 421 * fwnode. 7b2f3eb492dac76 Lucas Tanure 2021-12-17 422 */ 7b2f3eb492dac76 Lucas Tanure 2021-12-17 423 if (strncmp(hid, "CLSA0100", 8) != 0) f7f207375d4e6eb Lucas Tanure 2022-04-13 424 return -EINVAL; 7b2f3eb492dac76 Lucas Tanure 2021-12-17 425 7b2f3eb492dac76 Lucas Tanure 2021-12-17 426 /* check I2C address to assign the index */ 7b2f3eb492dac76 Lucas Tanure 2021-12-17 427 cs35l41->index = id == 0x40 ? 0 : 1; 775d667539a4dd8 Stefan Binding 2022-05-09 428 cs35l41->hw_cfg.spk_pos = cs35l41->index; 00f87ec74c3c096 Stefan Binding 2022-05-09 429 cs35l41->channel_index = 0; 8c286a0f973a812 Lucas Tanure 2022-01-17 430 cs35l41->reset_gpio = gpiod_get_index(physdev, NULL, 0, GPIOD_OUT_HIGH); b8388a1aba32bef Lucas Tanure 2022-04-13 431 cs35l41->hw_cfg.bst_type = CS35L41_EXT_BOOST_NO_VSPK_SWITCH; de8cab7b38d74e7 Stefan Binding 2022-05-09 432 hw_cfg->gpio2.func = CS35L41_GPIO2_INT_OPEN_DRAIN; de8cab7b38d74e7 Stefan Binding 2022-05-09 433 hw_cfg->gpio2.valid = true; 2603c974b45dbfe Lucas Tanure 2022-04-13 434 cs35l41->hw_cfg.valid = true; 8c286a0f973a812 Lucas Tanure 2022-01-17 435 put_device(physdev); 7b2f3eb492dac76 Lucas Tanure 2021-12-17 436 f7f207375d4e6eb Lucas Tanure 2022-04-13 437 return 0; 7b2f3eb492dac76 Lucas Tanure 2021-12-17 438 } 7b2f3eb492dac76 Lucas Tanure 2021-12-17 439 -- 0-DAY CI Kernel Test Service https://01.org/lkp
