On 2022-07-08 7:28 PM, Mark Brown wrote:
On Thu, Jul 07, 2022 at 02:41:47PM +0200, Cezary Rojewski wrote:
return AVS_IPC_RET(ret);
}
+ avs_ipc_block(adev->ipc);
avs_dsp_op(adev, int_control, false);
snd_hdac_ext_bus_ppcap_int_enable(bus, false);
The fact that there's no matching change to unblock is fine since
there's already code the paths starting the DSP which does that.
True. While it may be questioned why this line wasn't here from the get
go, in practice it was redundant - nothing was ever "asking" driver for
anything while it was asleep.
One of the next series in line is debugfs-related one. We could either
have every single file do PM manipulation on its own or allow for fileop
to fail gracefully if the device was asleep. Lately we revisited the
subject and decided to move away from the first option - not every
fileop will be resuming the device.
Regards,
Czarek
