On 7/6/2022 11:57 AM, Raphael-Xu wrote:
diff --git a/sound/soc/codecs/tas2780.c b/sound/soc/codecs/tas2780.c
new file mode 100644
index 000000000000..e6923c791b49
--- /dev/null
+++ b/sound/soc/codecs/tas2780.c
@@ -0,0 +1,693 @@
+// SPDX-License-Identifier: GPL-2.0
+// Driver for the Texas Instruments TAS2780 Mono
+// Audio amplifier
+// Copyright (C) 2022 Texas Instruments Inc.
+
I noticed one more thing, are all those headers really needed?
+#include <linux/module.h>
+#include <linux/moduleparam.h>
I see no module parameters in code?
+#include <linux/err.h>
+#include <linux/init.h>
This seems to be used mainly for marking functions as __init etc. which
doesn't seem to be done here?
+#include <linux/pm.h>
+#include <linux/i2c.h>
+#include <linux/gpio.h>
+#include <linux/gpio/consumer.h>
+#include <linux/regmap.h>
+#include <linux/of.h>
+#include <linux/of_gpio.h>
+#include <sound/soc.h>
+#include <sound/pcm.h>
+#include <sound/pcm_params.h>
+#include <sound/initval.h>
This one also seems to define things that aren't used in code?
+#include <sound/tlv.h>
