On Tue, Jul 05, 2022 at 07:47:02PM +0200, Krzysztof Kozlowski wrote: > The Qualcomm SDM845 sound card bindings are almost the same as SM8250, > except "pin-switches" and "widgets" properties. These were not > documented in SDM845 text bindings but are actually valid for SDM845. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > --- > > Changes since v1: > 1. Integrate into SM8250 instead of creating new file (Stephan). > > Cc: Stephan Gerhold <stephan@xxxxxxxxxxx> > --- > .../devicetree/bindings/sound/qcom,sdm845.txt | 91 ------------------- > .../bindings/sound/qcom,sm8250.yaml | 1 + > 2 files changed, 1 insertion(+), 91 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/sound/qcom,sdm845.txt > > diff --git a/Documentation/devicetree/bindings/sound/qcom,sdm845.txt b/Documentation/devicetree/bindings/sound/qcom,sdm845.txt > deleted file mode 100644 > index de4c604641da..000000000000 > --- a/Documentation/devicetree/bindings/sound/qcom,sdm845.txt > +++ /dev/null > @@ -1,91 +0,0 @@ [...] > -- compatible: > - Usage: required > - Value type: <stringlist> > - Definition: must be one of this > - "qcom,sdm845-sndcard" > - "qcom,db845c-sndcard" > - "lenovo,yoga-c630-sndcard" [...] > diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml > index 4ecd4080bb96..7cdf9e9f4dd3 100644 > --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml > +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml > @@ -18,6 +18,7 @@ properties: > enum: > - qcom,apq8016-sbc-sndcard > - qcom,msm8916-qdsp6-sndcard > + - qcom,sdm845-sndcard > - qcom,sm8250-sndcard > - qcom,qrb5165-rb5-sndcard > Looks like you forgot the db845c and lenovo compatible? :) If you add them feel free to add my: Reviewed-by: Stephan Gerhold <stephan@xxxxxxxxxxx> Thanks! Stephan
