On Tue, Jul 5, 2022 at 3:19 PM Péter Ujfalusi <peter.ujfalusi@xxxxxxxxxxxxxxx> wrote: > On 04/07/2022 19:19, Andy Shevchenko wrote: > > On Mon, Jul 04, 2022 at 10:31:48AM +0300, Péter Ujfalusi wrote: > >> On 03/07/2022 17:35, Andy Shevchenko wrote: ... > >> + return sof_acpi_probe(pdev, (const struct sof_dev_desc *)id->driver_data); > >> } > > > >> We don't use the desc in sof_broadwell_probe(), so we can just pass the id->driver_data > > > > I prefer not to cast inside the function parameters when it's not about POD. > > Fair enough. > > How about assigning desc before it is used? As answered in the other email, I'm fine to modify the change accordingly. -- With Best Regards, Andy Shevchenko