On Mon, Jun 27, 2022 at 6:42 PM Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx> wrote: > > The conversion of the set_fmt callback to direct clock specification > included a small typo, correct the affected code. sound/soc/samsung/s3c24xx-i2s.c: In function 's3c24xx_i2s_set_fmt': >> sound/soc/samsung/s3c24xx-i2s.c:173:14: error: 'SND_SOC_DAIFMT_BC_CFC' undeclared (first use in this function); did you mean 'SND_SOC_DAIFMT_BC_FC'? 173 | case SND_SOC_DAIFMT_BC_CFC: | ^~~~~~~~~~~~~~~~~~~~~ | SND_SOC_DAIFMT_BC_FC Adding this actual error msg from the kernel test robot will be helpful. Reviewed-by: Souptick Joarder (HPE) <jrdr.linux@xxxxxxxxx> > > Fixes: 0b491c7c1b25 ("ASoC: samsung: Update to use set_fmt_new callback") > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Signed-off-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx> > --- > > Changes since v1: > - Correct fixes tag. > > sound/soc/samsung/s3c24xx-i2s.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/samsung/s3c24xx-i2s.c b/sound/soc/samsung/s3c24xx-i2s.c > index 4082ad7cbcc11..c1a314b86b155 100644 > --- a/sound/soc/samsung/s3c24xx-i2s.c > +++ b/sound/soc/samsung/s3c24xx-i2s.c > @@ -170,7 +170,7 @@ static int s3c24xx_i2s_set_fmt(struct snd_soc_dai *cpu_dai, > pr_debug("hw_params r: IISMOD: %x \n", iismod); > > switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) { > - case SND_SOC_DAIFMT_BC_CFC: > + case SND_SOC_DAIFMT_BC_FC: > iismod |= S3C2410_IISMOD_SLAVE; > break; > case SND_SOC_DAIFMT_BP_FP: > -- > 2.30.2 >