Hi Stefan, Thank you for the patch! Yet something to improve: [auto build test ERROR on rafael-pm/linux-next] [also build test ERROR on broonie-sound/for-next linus/master v5.19-rc4 next-20220627] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Stefan-Binding/Read-_SUB-from-ACPI-to-be-able-to-identify-firmware/20220627-221508 base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next config: um-x86_64_defconfig (https://download.01.org/0day-ci/archive/20220627/202206272354.ESTdiIXg-lkp@xxxxxxxxx/config) compiler: gcc-11 (Debian 11.3.0-3) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/93ba13d4b3636b5cf2ff4d9185aa73f059cc7b2a git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Stefan-Binding/Read-_SUB-from-ACPI-to-be-able-to-identify-firmware/20220627-221508 git checkout 93ba13d4b3636b5cf2ff4d9185aa73f059cc7b2a # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=um SUBARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): In file included from init/main.c:30: >> include/linux/acpi.h:1028:1: error: expected identifier or '(' before '{' token 1028 | { | ^ init/main.c:769:20: warning: no previous prototype for 'arch_post_acpi_subsys_init' [-Wmissing-prototypes] 769 | void __init __weak arch_post_acpi_subsys_init(void) { } | ^~~~~~~~~~~~~~~~~~~~~~~~~~ init/main.c:781:20: warning: no previous prototype for 'mem_encrypt_init' [-Wmissing-prototypes] 781 | void __init __weak mem_encrypt_init(void) { } | ^~~~~~~~~~~~~~~~ init/main.c:783:20: warning: no previous prototype for 'poking_init' [-Wmissing-prototypes] 783 | void __init __weak poking_init(void) { } | ^~~~~~~~~~~ In file included from init/main.c:30: include/linux/acpi.h:1027:27: warning: 'acpi_get_subsystem_id' declared 'static' but never defined [-Wunused-function] 1027 | static inline const char *acpi_get_subsystem_id(acpi_handle handle); | ^~~~~~~~~~~~~~~~~~~~~ -- In file included from kernel/sysctl.c:55: >> include/linux/acpi.h:1028:1: error: expected identifier or '(' before '{' token 1028 | { | ^ include/linux/acpi.h:1027:27: warning: 'acpi_get_subsystem_id' declared 'static' but never defined [-Wunused-function] 1027 | static inline const char *acpi_get_subsystem_id(acpi_handle handle); | ^~~~~~~~~~~~~~~~~~~~~ -- In file included from include/linux/i2c.h:13, from drivers/input/mouse/synaptics.c:30: >> include/linux/acpi.h:1028:1: error: expected identifier or '(' before '{' token 1028 | { | ^ include/linux/acpi.h:1027:27: warning: 'acpi_get_subsystem_id' declared 'static' but never defined [-Wunused-function] 1027 | static inline const char *acpi_get_subsystem_id(acpi_handle handle); | ^~~~~~~~~~~~~~~~~~~~~ drivers/input/mouse/synaptics.c:164:27: warning: 'smbus_pnp_ids' defined but not used [-Wunused-const-variable=] 164 | static const char * const smbus_pnp_ids[] = { | ^~~~~~~~~~~~~ vim +1028 include/linux/acpi.h 1026 1027 static inline const char *acpi_get_subsystem_id(acpi_handle handle); > 1028 { 1029 return ERR_PTR(-ENODEV); 1030 } 1031 -- 0-DAY CI Kernel Test Service https://01.org/lkp
