On Sat, Jun 25, 2022 at 12:01 AM Krzysztof Kozlowski <
krzysztof.kozlowski@xxxxxxxxxx> wrote:
> On 23/06/2022 12:28, Shengjiu Wang wrote:
> > Convert the NXP MICFIL binding to DT schema format using json-schema.
> >
> > Signed-off-by: Shengjiu Wang <shengjiu.wang@xxxxxxx>
> > ---
> > .../devicetree/bindings/sound/fsl,micfil.txt | 33 ---------
> > .../devicetree/bindings/sound/fsl,micfil.yaml | 73 +++++++++++++++++++
> > 2 files changed, 73 insertions(+), 33 deletions(-)
> > delete mode 100644
> Documentation/devicetree/bindings/sound/fsl,micfil.txt
> > create mode 100644
> Documentation/devicetree/bindings/sound/fsl,micfil.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/sound/fsl,micfil.txt
> b/Documentation/devicetree/bindings/sound/fsl,micfil.txt
> > deleted file mode 100644
> > index 1ea05d4996c7..000000000000
> > --- a/Documentation/devicetree/bindings/sound/fsl,micfil.txt
> > +++ /dev/null
> > @@ -1,33 +0,0 @@
> > -NXP MICFIL Digital Audio Interface (MICFIL).
> > -
> > -The MICFIL digital interface provides a 16-bit audio signal from a PDM
> > -microphone bitstream in a configurable output sampling rate.
> > -
> > -Required properties:
> > -
> > - - compatible : Compatible list, contains
> "fsl,imx8mm-micfil"
> > - or "fsl,imx8mp-micfil"
> > -
> > - - reg : Offset and length of the register set
> for the device.
> > -
> > - - interrupts : Contains the micfil interrupts.
> > -
> > - - clocks : Must contain an entry for each entry in
> clock-names.
> > -
> > - - clock-names : Must include the "ipg_clk" for register
> access and
> > - "ipg_clk_app" for internal micfil clock.
> > -
> > - - dmas : Generic dma devicetree binding as described in
> > - Documentation/devicetree/bindings/dma/dma.txt.
> > -
> > -Example:
> > -micfil: micfil@30080000 {
> > - compatible = "fsl,imx8mm-micfil";
> > - reg = <0x0 0x30080000 0x0 0x10000>;
> > - interrupts = <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>,
> > - <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>;
> > - clocks = <&clk IMX8MM_CLK_PDM_IPG>,
> > - <&clk IMX8MM_CLK_PDM_ROOT>;
> > - clock-names = "ipg_clk", "ipg_clk_app";
> > - dmas = <&sdma2 24 26 0x80000000>;
> > -};
> > diff --git a/Documentation/devicetree/bindings/sound/fsl,micfil.yaml
> b/Documentation/devicetree/bindings/sound/fsl,micfil.yaml
> > new file mode 100644
> > index 000000000000..74c77f4cf7a4
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/fsl,micfil.yaml
> > @@ -0,0 +1,73 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/sound/fsl,micfil.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: NXP MICFIL Digital Audio Interface (MICFIL)
> > +
> > +maintainers:
> > + - Shengjiu Wang <shengjiu.wang@xxxxxxx>
> > +
> > +description: |
> > + The MICFIL digital interface provides a 16-bit or 24-bit audio signal
> > + from a PDM microphone bitstream in a configurable output sampling
> rate.
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - fsl,imx8mm-micfil
> > + - fsl,imx8mp-micfil
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 4
>
> You should describe the interrupts/items. Similarly to clocks.
>
>
> Ok, let me update it.
Best regards
Wang shengjiu
