On 10-06-22, 09:51, Bard Liao wrote:
> From: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
>
> The bus sdw_drv_remove() and sdw_drv_shutdown() helpers are used
> conditionally, if the driver provides these routines.
>
> These helpers already test if the driver provides a .remove or
> .shutdown callback, so there's no harm in invoking the
> sdw_drv_remove() and sdw_drv_shutdown() unconditionally.
Okay sounds good
> In addition, the current code is imbalanced with
> dev_pm_domain_attach() called from sdw_drv_probe(), but
> dev_pm_domain_detach() called from sdw_drv_remove() only if the driver
> provides a .remove callback.
Am not sure I follow what is imbalance, pm_domain_attach/detach?
> Fixes: 9251345dca24b ("soundwire: Add SoundWire bus type")
How is this a fix is still unclear to me. At best I think this is code
optimization and removing checks which maybe redundant.
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
> Reviewed-by: Rander Wang <rander.wang@xxxxxxxxx>
> Signed-off-by: Bard Liao <yung-chuan.liao@xxxxxxxxxxxxxxx>
> ---
> drivers/soundwire/bus_type.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/soundwire/bus_type.c b/drivers/soundwire/bus_type.c
> index 893296f3fe39..b81e04dd3a9f 100644
> --- a/drivers/soundwire/bus_type.c
> +++ b/drivers/soundwire/bus_type.c
> @@ -193,12 +193,8 @@ int __sdw_register_driver(struct sdw_driver *drv, struct module *owner)
>
> drv->driver.owner = owner;
> drv->driver.probe = sdw_drv_probe;
> -
> - if (drv->remove)
> - drv->driver.remove = sdw_drv_remove;
> -
> - if (drv->shutdown)
> - drv->driver.shutdown = sdw_drv_shutdown;
> + drv->driver.remove = sdw_drv_remove;
> + drv->driver.shutdown = sdw_drv_shutdown;
>
> return driver_register(&drv->driver);
> }
> --
> 2.17.1
--
~Vinod
