Hi Mark Current ASoC has fixup both snd_soc_of_get_dai_link_cpus/codecs(). I guess cpu was copied from codec, but it is using "codec" naming everwhere in "cpu" function. It is strange, and thus, error case will be issue (It should call cpu function instead of codec). This patch tidyup it, and try to cleanup. [1/2] is for bug-fix, [2/2] is for new feature. It needs Tested-by/Reviewed-by/Acked-by from someone. Kuninori Morimoto (2): ASoC: soc-core.c: fixup snd_soc_of_get_dai_link_cpus() ASoC: soc-core.c: share code for snd_soc_of_get_dai_link_cpus/codecs() sound/soc/soc-core.c | 146 ++++++++++++++++++++++--------------------- 1 file changed, 75 insertions(+), 71 deletions(-) -- 2.25.1