On Thu, 16 Jun 2022 02:21:42 +0200, Takashi Sakamoto wrote: > > Hi, > > I realized that the second patch still includes a bug that shorter > buffer is allocated for block request than received length since the > computation is aligned to 4 without care of remainder. > > Actually in the case of block request, the length is not necessarily > multiples of 4 and the packet payload has enough size of field with > padding to be aligned to 4, according to 1394 OHCI specification. In the > implementation of firewire-core driver, the field is copied without > the padding. > > Please abandon them. I'm sorry to trouble you. So this implies that the type declaration of data[] rather looks wrong? Takashi
