> It feels like a lot of the noise in this patch is due to adding > additional error handling, unrelated to the real change you're making. > Maybe that deserves a separate patch? The error handling is to detect the failure of switching LRCLK. If LRCLK is OFF, we don’t want the BCLK to be ON. So the error handling in the patch is relevant. > I mentioned this off-list, but the 2nd-line indentation alignment *used* > to be in a very particular style, and you've moved that around a lot. To > match the previous style, it should be: > > ret = regmap_update_bits(i2s->regmap, I2S_DMACR, > I2S_DMACR_TDE_ENABLE, > I2S_DMACR_TDE_ENABLE); > > (BTW, if you're using Gmail to view this, you're going to have no idea > what I'm talking about, since it doesn't do whitespace or monospace font > correctly...) > > The same applies throughout; most of the 2nd-line, 3rd-line, ... > indentation is a little weird. Yes, let me fix the indentation in V3, thanks!
