Hi Judy, Thank you for the patch! Yet something to improve: [auto build test ERROR on rockchip/for-next] [also build test ERROR on broonie-sound/for-next robh/for-next linus/master v5.19-rc2 next-20220616] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Judy-Hsiao/ASoC-rockchip-i2s-switch-BCLK-to-GPIO/20220617-000041 base: https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git for-next config: arc-randconfig-r043-20220616 (https://download.01.org/0day-ci/archive/20220617/202206170216.M52eiJwN-lkp@xxxxxxxxx/config) compiler: arc-elf-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/322064314e50b113217aa4c7412e2431defea08f git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Judy-Hsiao/ASoC-rockchip-i2s-switch-BCLK-to-GPIO/20220617-000041 git checkout 322064314e50b113217aa4c7412e2431defea08f # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash sound/soc/rockchip/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): sound/soc/rockchip/rockchip_i2s.c: In function 'rockchip_snd_rxctrl': sound/soc/rockchip/rockchip_i2s.c:247:16: error: 'return' with a value, in function returning void [-Werror=return-type] 247 | return ret; | ^~~ sound/soc/rockchip/rockchip_i2s.c:188:13: note: declared here 188 | static void rockchip_snd_rxctrl(struct rk_i2s_dev *i2s, int on) | ^~~~~~~~~~~~~~~~~~~ sound/soc/rockchip/rockchip_i2s.c: In function 'rockchip_i2s_trigger': >> sound/soc/rockchip/rockchip_i2s.c:485:29: error: void value not ignored as it ought to be 485 | ret = rockchip_snd_rxctrl(i2s, 1); | ^ sound/soc/rockchip/rockchip_i2s.c:498:29: error: void value not ignored as it ought to be 498 | ret = rockchip_snd_rxctrl(i2s, 0); | ^ cc1: some warnings being treated as errors vim +485 sound/soc/rockchip/rockchip_i2s.c 473 474 static int rockchip_i2s_trigger(struct snd_pcm_substream *substream, 475 int cmd, struct snd_soc_dai *dai) 476 { 477 struct rk_i2s_dev *i2s = to_info(dai); 478 int ret = 0; 479 480 switch (cmd) { 481 case SNDRV_PCM_TRIGGER_START: 482 case SNDRV_PCM_TRIGGER_RESUME: 483 case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: 484 if (substream->stream == SNDRV_PCM_STREAM_CAPTURE) > 485 ret = rockchip_snd_rxctrl(i2s, 1); 486 else 487 ret = rockchip_snd_txctrl(i2s, 1); 488 if (ret < 0) 489 return ret; 490 i2s_pinctrl_select_bclk_on(i2s); 491 break; 492 case SNDRV_PCM_TRIGGER_SUSPEND: 493 case SNDRV_PCM_TRIGGER_STOP: 494 case SNDRV_PCM_TRIGGER_PAUSE_PUSH: 495 if (substream->stream == SNDRV_PCM_STREAM_CAPTURE) { 496 if (!i2s->tx_start) 497 i2s_pinctrl_select_bclk_off(i2s); 498 ret = rockchip_snd_rxctrl(i2s, 0); 499 } else { 500 if (!i2s->rx_start) 501 i2s_pinctrl_select_bclk_off(i2s); 502 ret = rockchip_snd_txctrl(i2s, 0); 503 } 504 break; 505 default: 506 ret = -EINVAL; 507 break; 508 } 509 510 return ret; 511 } 512 -- 0-DAY CI Kernel Test Service https://01.org/lkp
