From: Lv Ruyi <lv.ruyi@xxxxxxxxxx> If data is null, request->data wouldn't be assigned value. It is random value, but we use it in handle_exclusive_region_request() and handle_fcp_region_request() later. Fix the bug by initializing it. (Revised by Takashi Sakamoto to rebase to the previous patch.) Reported-by: Zeal Robot <zealci@xxxxxxxxxx> Signed-off-by: Lv Ruyi <lv.ruyi@xxxxxxxxxx> Signed-off-by: Takashi Sakamoto <o-takashi@xxxxxxxxxxxxx> --- drivers/firewire/core-transaction.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firewire/core-transaction.c b/drivers/firewire/core-transaction.c index 4604a9d97fd1..613aff624391 100644 --- a/drivers/firewire/core-transaction.c +++ b/drivers/firewire/core-transaction.c @@ -779,7 +779,7 @@ static struct fw_request *allocate_request(struct fw_card *card, return NULL; } - request = kmalloc(struct_size(request, data, length / sizeof(request->data[0])), + request = kzalloc(struct_size(request, data, length / sizeof(request->data[0])), GFP_ATOMIC); if (request == NULL) return NULL; -- 2.34.1
