Hi Dan,
On Wed, 2022-06-15 at 11:19 +0300, Dan Carpenter wrote:
> This should return PTR_ERR() instead of IS_ERR().
>
> Fixes: e0100bfd383c ("ASoC: SOF: mediatek: Add mt8186 ipc support")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> sound/soc/sof/mediatek/mt8186/mt8186.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/sof/mediatek/mt8186/mt8186.c b/sound/soc/sof/mediatek/mt8186/mt8186.c
> index 3333a0634e29..e006532caf2f 100644
> --- a/sound/soc/sof/mediatek/mt8186/mt8186.c
> +++ b/sound/soc/sof/mediatek/mt8186/mt8186.c
> @@ -392,7 +392,7 @@ static int mt8186_dsp_probe(struct snd_sof_dev *sdev)
> PLATFORM_DEVID_NONE,
> pdev, sizeof(*pdev));
> if (IS_ERR(priv->ipc_dev)) {
> - ret = IS_ERR(priv->ipc_dev);
> + ret = PTR_ERR(priv->ipc_dev);
> dev_err(sdev->dev, "failed to create mtk-adsp-ipc device\n");
> goto err_adsp_off;
> }
Thank you for finding this bug.
Best regards,
TingHan
