On 2022-06-10 2:36 PM, Cezary Rojewski wrote:
A number of patches improving overall quality and readability of
haswell.c and broadwell.c source files found in sound/soc/intel/boards.
Both files are first renamed and only then actual changes are being
incrementally added. The respective names are: hsw_rt5640 and bdw_rt286
to match the pattern found in more recent boards.
Most patches bring no functional change - the more impactful patches at
are placed the end:
Refactor of suspend/resume flow for the bdw_rt286 board by dropping
dev->remove() in favour of card->remove() and adjust jack handling to
reduce code size slightly by implementing card_set_jack().
The last patch is removing of FE DAI ops. Given the existence of
platform FE DAI capabilities (either static declaration or through
topology file), this code is redundant.
Hello,
While this patchset reorganizes and rewords code of two boards in
question, module (kernel module) names are unchanged. Currently those
two are:
- snd_soc_sst_haswell.ko
- snd_soc_sst_broadwell.ko
My question is: Is it viable to reword these two?
Both modules accept no custom parameters, perhaps *dyndbg* is the only
possibility so the impact is reduced.
Regards,
Czarek
