On Thu, Jun 9, 2022 at 6:21 PM Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx> wrote: > > > >> Shouldn't the return of sdw_acpi_find_one() be trapped, e.g. with > >> > >> return acpi_dev_for_each_child(parent, sdw_acpi_find_one, bus); > > > > Sure, I'll do that. Thanks! > > I also added this EXPORT_SYMBOL to work-around link errors, not sure if > this is in your tree already? One of the previous patches in the series is adding the export. > diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c > > index 86fa61a21826c..ade6259c19af6 100644 > > --- a/drivers/acpi/bus.c > > +++ b/drivers/acpi/bus.c > > @@ -1113,6 +1113,7 @@ int acpi_dev_for_each_child(struct acpi_device *adev, > > > > return device_for_each_child(&adev->dev, &adwc, > acpi_dev_for_one_check); > > } > > +EXPORT_SYMBOL_GPL(acpi_dev_for_each_child); > >
