Hi Mark, I love your patch! Perhaps something to improve: [auto build test WARNING on broonie-sound/for-next] [also build test WARNING on v5.18 next-20220603] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Mark-Brown/ASoC-wcd938x-Fix-event-generation-for-some-controls/20220605-162848 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20220606/202206060948.KAZcrRC8-lkp@xxxxxxxxx/config) compiler: gcc-11 (Debian 11.3.0-1) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/77b0604d37f40ad0f56da53a9a38ad0de298fa52 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Mark-Brown/ASoC-wcd938x-Fix-event-generation-for-some-controls/20220605-162848 git checkout 77b0604d37f40ad0f56da53a9a38ad0de298fa52 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash sound/soc/codecs/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): sound/soc/codecs/wcd938x.c: In function 'wcd938x_rx_hph_mode_put': >> sound/soc/codecs/wcd938x.c:2546:13: warning: unused variable 'change' [-Wunused-variable] 2546 | int change; | ^~~~~~ vim +/change +2546 sound/soc/codecs/wcd938x.c 2540 2541 static int wcd938x_rx_hph_mode_put(struct snd_kcontrol *kcontrol, 2542 struct snd_ctl_elem_value *ucontrol) 2543 { 2544 struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol); 2545 struct wcd938x_priv *wcd938x = snd_soc_component_get_drvdata(component); > 2546 int change; 2547 2548 if (wcd938x->hph_mode == ucontrol->value.enumerated.item[0]) 2549 return 0; 2550 2551 wcd938x->hph_mode = ucontrol->value.enumerated.item[0]; 2552 2553 return 1; 2554 } 2555 -- 0-DAY CI Kernel Test Service https://01.org/lkp
