On Thu, Jun 02, 2022 at 04:26:11PM +0000, Charles Keepax wrote: > On Thu, Jun 02, 2022 at 11:29:20AM +0200, Mark Brown wrote: > > Currently snd_soc_info_volsw_sx() is implemented indirectly, wrapping > > snd_soc_info_volsw() and modifying the values it sets up rather than > > directly setting up the values reported to userspace. This makes it much > > harder to follow what the intended behaviour of these controls is. Let's > > rewrite the function to be self contained with a clarifying comment at the > > top in an effort to help maintainability. > > > > Signed-off-by: Mark Brown <broonie@xxxxxxxxxx> > > --- > > Reviewed-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx> Tested-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx> On cs35l41, seems to work fine to me. Thanks, Charles