ok,we will implement these two functions later. Best Regards Cliff Cai -----Original Message----- From: Mark Brown [mailto:broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx] Sent: Monday, May 12, 2008 7:54 PM To: Bryan Wu Cc: liam.girdwood@xxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Cliff Cai; alsa-devel@xxxxxxxxxxxxxxxx Subject: Re: [PATCH 1/1] [ASOC]: AD1980 audio codec ASOC driver On Mon, May 12, 2008 at 06:45:12PM +0800, Bryan Wu wrote: > From: Cliff Cai <cliff.cai@xxxxxxxxxx> > > Signed-off-by: Cliff Cai <cliff.cai@xxxxxxxxxx> > Signed-off-by: Bryan Wu <cooloney@xxxxxxxxxx> Thanks, I've applied this to the ASoC git tree. CCing in alsa-devel@xxxxxxxxxxxxxxxx - ALSA patches should go via there. > +static int ad1980_soc_suspend(struct platform_device *pdev, > + pm_message_t state) > +{ > + return 0; > +} > + > +static int ad1980_soc_resume(struct platform_device *pdev) { > + return 0; > +} Are you sure about these? I would expect the suspend and resume functions to either do some register writes or be omitted if they don't do anything. Standard AC97 codecs would have some power management via register 0x26 if they were doing anything. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
