On 5/23/22 16:29, Dag B wrote: > On 23.05.2022 22:30, Pierre-Louis Bossart wrote: >> On 5/23/22 15:20, Dag B wrote: >>> Without the attached patch, the s/pdif output on the Hades Canyon NUC >>> does not work. >>> >>> "Well known" issue, less known fix. As far as I can tell, there is no >>> risk of any averse side-effects. But a bonus fix is enabling on-wire >>> headset microphone, by chaining the right 'model' choice for the >>> hardware. >>> >>> If I should Cc: someone directly for this patch to be picked up, please >>> let me know. >>> >>> >>> I have been running with this patch for half a year or so. >>> >>> Patch passes checkpatch.pl >>> >>> Patch is based on what 'cyber4o' posted on the insanelymac forum [1]. >>> All the glory to this person, any error is likely mine. >> Thanks for the patch. >> >> You would need a Signed-off-by tag for this patch, and CC: Takashi >> (added) >> >> + [ALC700_FIXUP_NUC_SPDIF] = { >> >> Maybe use HC_NUC, there are multiple versions of those devices? >> >> + .type = HDA_FIXUP_FUNC, >> + .v.func = alc700_fixup_nuc_spdif, >> >> alc700_fixup_hc_nuc_spdif ? >> >> + .chained = true, >> + .chain_id = ALC269_FIXUP_DELL1_MIC_NO_PRESENCE, >> >> that chain_id doesn't seem quite right? >> > Thank you for reviewing this. I have made adjustments as suggested. > Revised patch attached. > > The chain_id may appear odd, I can assure you that it does the job. I > picked up the suggestion from the excellent Arch Linux wiki: > > https://wiki.archlinux.org/title/Intel_NUC#Hades_Canyon_NUC_-_No_External_Microphones Parts of my comment was the reference to ALC269 when this is an ALC700, but it seems the two parts are identical if I understand this definition well: ALC269_TYPE_ALC700, The other point was the reference to Dell when this isn't a Dell platform. ALC269_FIXUP_DELL1_MIC_NO_PRESENCE may do the job but so far it's only used for Dell platforms, so it's a bit confusing. > So my patch equates to: > > a) creating a fixup for enabling spdif > > and > > b) making the new "model=nuc-hc" equate to the spdif fix + > "model=dell-headset-multi" > > I hope this is acceptable. As stated, I have used this solution for half > a year or so. > > |Signed-off-by: Dag Bakke <dag@xxxxxxxxx>| usually this comes inside the patch with a git commit title and message. > > Dag B > > > >>> Some other users with issues: [2] [3] >>> >>> >>> Dag Bakke >>> >>> >>> [1] >>> https://www.insanelymac.com/forum/topic/339291-guide-hac-mini-osx-mojave-on-intel-hades-canyon-nuc8i7hvknuc8i7hnk/page/8/ >>> >>> >>> >>> 2]https://bbs.archlinux.org/viewtopic.php?id=270917 >>> >>> [3] >>> https://www.reddit.com/r/intelnuc/comments/9ft9x8/any_linux_users_got_the_spdif_toslink_to_work_on/ >>> >>> >>> >>>