RE: [PATCH 2/2 v3] dt-bindings: ADAU7118: add new entries for pins drive strength

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Dylan Laduranty <dylan.laduranty@xxxxxxxxxxx>
> Sent: Tuesday, May 17, 2022 10:40 AM
> To: alsa-devel@xxxxxxxxxxxxxxxx; Sa, Nuno <Nuno.Sa@xxxxxxxxxx>
> Subject: Re: [PATCH 2/2 v3] dt-bindings: ADAU7118: add new entries
> for pins drive strength
> 
> [External]
> 
> Hi Nuno,
> 
> > Hi Dylan,
> >
> > > -----Original Message-----
> > > From: Dylan Laduranty <dylan.laduranty@xxxxxxxxxxx>
> > > Sent: Tuesday, May 17, 2022 7:48 AM
> > > To: alsa-devel@xxxxxxxxxxxxxxxx
> > > Cc: Sa, Nuno <Nuno.Sa@xxxxxxxxxx>; Dylan Laduranty
> > > <dylan.laduranty@xxxxxxxxxxx>
> > > Subject: [PATCH 2/2 v3] dt-bindings: ADAU7118: add new entries
> for
> > > pins drive strength
> > >
> > > [External]
> > >
> > > Update driver doc with new entries for managing pins drive
> strength.
> > > Add a table to describe possible values for each entry.
> > >
> > > Signed-off-by: Dylan Laduranty <dylan.laduranty@xxxxxxxxxxx>
> > > ---
> >
> > Just a note for the future. In my previous review I said something
> > like:
> >
> > "
> > ... With that fixed:
> >
> > Reviewed-by: Nuno Sá <nuno.sa@xxxxxxxxxx>
> > "
> >
> > Hence, you could/should have included my 'Reviewed-by' tag in v3.
> I apologize, this is my first contribution to Linux kernel so I am not
> comfortable with this yet. I'll resend this serie later today.
> 
No need to apologize...

I don't think you need to re-send the patches as the maintainer can
apply the tags while applying the patches. So I would not send new
patches unless explicitly requested by the maintainer...

- Nuno Sá 





[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux