Hi Stefan, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tiwai-sound/for-next] [also build test WARNING on v5.18-rc6 next-20220510] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Stefan-Binding/ALSA-hda-cs8409-Add-support-for-Odin-Laptop-Variants/20220511-001936 base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next config: i386-randconfig-c001-20220509 (https://download.01.org/0day-ci/archive/20220511/202205110948.6wfXVVvs-lkp@xxxxxxxxx/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 18dd123c56754edf62c7042dcf23185c3727610f) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/e834cdf9c71c45212904ba82b5b7e49d45810deb git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Stefan-Binding/ALSA-hda-cs8409-Add-support-for-Odin-Laptop-Variants/20220511-001936 git checkout e834cdf9c71c45212904ba82b5b7e49d45810deb # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash sound/pci/hda/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): >> sound/pci/hda/patch_cs8409.c:1033:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough] default: ^ sound/pci/hda/patch_cs8409.c:1033:2: note: insert 'break;' to avoid fall-through default: ^ break; 1 warning generated. vim +1033 sound/pci/hda/patch_cs8409.c 8c70461bbb83cf Lucas Tanure 2021-08-11 996 8c70461bbb83cf Lucas Tanure 2021-08-11 997 /* Vendor specific HW configuration 8c70461bbb83cf Lucas Tanure 2021-08-11 998 * PLL, ASP, I2C, SPI, GPIOs, DMIC etc... 8c70461bbb83cf Lucas Tanure 2021-08-11 999 */ 8c70461bbb83cf Lucas Tanure 2021-08-11 1000 static void cs8409_cs42l42_hw_init(struct hda_codec *codec) 8c70461bbb83cf Lucas Tanure 2021-08-11 1001 { 8c70461bbb83cf Lucas Tanure 2021-08-11 1002 const struct cs8409_cir_param *seq = cs8409_cs42l42_hw_cfg; 8c70461bbb83cf Lucas Tanure 2021-08-11 1003 const struct cs8409_cir_param *seq_bullseye = cs8409_cs42l42_bullseye_atn; 8c70461bbb83cf Lucas Tanure 2021-08-11 1004 struct cs8409_spec *spec = codec->spec; 24f7ac3d3b6b70 Lucas Tanure 2021-08-11 1005 struct sub_codec *cs42l42 = spec->scodecs[CS8409_CODEC0]; 8c70461bbb83cf Lucas Tanure 2021-08-11 1006 8c70461bbb83cf Lucas Tanure 2021-08-11 1007 if (spec->gpio_mask) { ccff0064a7ce8e Stefan Binding 2021-08-11 1008 snd_hda_codec_write(codec, CS8409_PIN_AFG, 0, AC_VERB_SET_GPIO_MASK, ccff0064a7ce8e Stefan Binding 2021-08-11 1009 spec->gpio_mask); ccff0064a7ce8e Stefan Binding 2021-08-11 1010 snd_hda_codec_write(codec, CS8409_PIN_AFG, 0, AC_VERB_SET_GPIO_DIRECTION, ccff0064a7ce8e Stefan Binding 2021-08-11 1011 spec->gpio_dir); ccff0064a7ce8e Stefan Binding 2021-08-11 1012 snd_hda_codec_write(codec, CS8409_PIN_AFG, 0, AC_VERB_SET_GPIO_DATA, ccff0064a7ce8e Stefan Binding 2021-08-11 1013 spec->gpio_data); 8c70461bbb83cf Lucas Tanure 2021-08-11 1014 } 8c70461bbb83cf Lucas Tanure 2021-08-11 1015 8c70461bbb83cf Lucas Tanure 2021-08-11 1016 for (; seq->nid; seq++) 8c70461bbb83cf Lucas Tanure 2021-08-11 1017 cs8409_vendor_coef_set(codec, seq->cir, seq->coeff); 8c70461bbb83cf Lucas Tanure 2021-08-11 1018 24f7ac3d3b6b70 Lucas Tanure 2021-08-11 1019 if (codec->fixup_id == CS8409_BULLSEYE) { 8c70461bbb83cf Lucas Tanure 2021-08-11 1020 for (; seq_bullseye->nid; seq_bullseye++) 8c70461bbb83cf Lucas Tanure 2021-08-11 1021 cs8409_vendor_coef_set(codec, seq_bullseye->cir, seq_bullseye->coeff); 24f7ac3d3b6b70 Lucas Tanure 2021-08-11 1022 } 8c70461bbb83cf Lucas Tanure 2021-08-11 1023 6581a045d54c6a Stefan Binding 2022-03-28 1024 switch (codec->fixup_id) { 6581a045d54c6a Stefan Binding 2022-03-28 1025 case CS8409_CYBORG: 6581a045d54c6a Stefan Binding 2022-03-28 1026 case CS8409_WARLOCK_MLK_DUAL_MIC: 8c70461bbb83cf Lucas Tanure 2021-08-11 1027 /* DMIC1_MO=00b, DMIC1/2_SR=1 */ 8a7724535bacbb Stefan Binding 2022-03-28 1028 cs8409_vendor_coef_set(codec, CS8409_DMIC_CFG, 0x0003); 6581a045d54c6a Stefan Binding 2022-03-28 1029 break; e834cdf9c71c45 Stefan Binding 2022-05-10 1030 case CS8409_ODIN: e834cdf9c71c45 Stefan Binding 2022-05-10 1031 /* ASP1/2_xxx_EN=1, ASP1/2_MCLK_EN=0, DMIC1_SCL_EN=0 */ e834cdf9c71c45 Stefan Binding 2022-05-10 1032 cs8409_vendor_coef_set(codec, CS8409_PAD_CFG_SLW_RATE_CTRL, 0xfc00); 6581a045d54c6a Stefan Binding 2022-03-28 @1033 default: 6581a045d54c6a Stefan Binding 2022-03-28 1034 break; 6581a045d54c6a Stefan Binding 2022-03-28 1035 } 8c70461bbb83cf Lucas Tanure 2021-08-11 1036 24f7ac3d3b6b70 Lucas Tanure 2021-08-11 1037 cs42l42_resume(cs42l42); 8c70461bbb83cf Lucas Tanure 2021-08-11 1038 8c70461bbb83cf Lucas Tanure 2021-08-11 1039 /* Enable Unsolicited Response */ 8c70461bbb83cf Lucas Tanure 2021-08-11 1040 cs8409_enable_ur(codec, 1); 8c70461bbb83cf Lucas Tanure 2021-08-11 1041 } 8c70461bbb83cf Lucas Tanure 2021-08-11 1042 -- 0-DAY CI Kernel Test Service https://01.org/lkp
