On Sat, May 7, 2022 at 4:14 AM YueHaibing <yuehaibing@xxxxxxxxxx> wrote:
>
> sound/soc/mediatek/mt8195/mt8195-mt6359.c:1639:32: warning: ‘mt8195_mt6359_max98390_rt5682_card’ defined but not used [-Wunused-variable]
> 1639 | static struct mt8195_card_data mt8195_mt6359_max98390_rt5682_card = {
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> sound/soc/mediatek/mt8195/mt8195-mt6359.c:1634:32: warning: ‘mt8195_mt6359_rt1011_rt5682_card’ defined but not used [-Wunused-variable]
> 1634 | static struct mt8195_card_data mt8195_mt6359_rt1011_rt5682_card = {
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> sound/soc/mediatek/mt8195/mt8195-mt6359.c:1629:32: warning: ‘mt8195_mt6359_rt1019_rt5682_card’ defined but not used [-Wunused-variable]
> 1629 | static struct mt8195_card_data mt8195_mt6359_rt1019_rt5682_card = {
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Since all users of this driver do need CONFIG_OF anyway, there is no
> need to save a few bytes on kernel builds while CONFIG_OF disabled, so
> just remove the #ifdef to fix this warning.
>
> Fixes: 86a6b9c9dfff ("ASoC: mediatek: mt8195: add machine support for max98390 and rt5682")
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> ---
> v2: remove #ifdef block as Arnd suggested
Looks good to me,
Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
