On 2022/5/6 15:08, Arnd Bergmann wrote: > On Fri, May 6, 2022 at 4:26 AM YueHaibing <yuehaibing@xxxxxxxxxx> wrote: >> >> sound/soc/mediatek/mt8195/mt8195-mt6359.c:1639:32: warning: ‘mt8195_mt6359_max98390_rt5682_card’ defined but not used [-Wunused-variable] >> 1639 | static struct mt8195_card_data mt8195_mt6359_max98390_rt5682_card = { >> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> sound/soc/mediatek/mt8195/mt8195-mt6359.c:1634:32: warning: ‘mt8195_mt6359_rt1011_rt5682_card’ defined but not used [-Wunused-variable] >> 1634 | static struct mt8195_card_data mt8195_mt6359_rt1011_rt5682_card = { >> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> sound/soc/mediatek/mt8195/mt8195-mt6359.c:1629:32: warning: ‘mt8195_mt6359_rt1019_rt5682_card’ defined but not used [-Wunused-variable] >> 1629 | static struct mt8195_card_data mt8195_mt6359_rt1019_rt5682_card = { >> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> >> These variables is only used with CONFIG_OF, move it into the ifdef block. >> >> Fixes: 86a6b9c9dfff ("ASoC: mediatek: mt8195: add machine support for max98390 and rt5682") >> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx> > > It's generally better to remove the #ifdef rather than expanding it, > there is no need to > save a few bytes on kernel builds of this driver that disable > CONFIG_OF. Just drop > the of_match_ptr() macro as well. Sure, will do that in v2. > > > Arnd > > . >