Hi Greg, Thanks for your review. On Thu, 2022-05-05 at 23:10 +0200, Greg Kroah-Hartman wrote: > On Thu, May 05, 2022 at 01:30:48PM +0800, Tinghan Shen wrote: > > From: TingHan Shen <tinghan.shen@xxxxxxxxxxxx> > > > > Some of mediatek processors contain > > the Tensilica HiFix DSP for audio processing. > > > > The communication between Host CPU and DSP firmware is > > taking place using a shared memory area for message passing. > > > > ADSP IPC protocol offers (send/recv) interfaces using > > mediatek-mailbox APIs. > > > > We use two mbox channels to implement a request-reply protocol. > > > > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@xxxxxxxxxxxx> > > Signed-off-by: TingHan Shen <tinghan.shen@xxxxxxxxxxxx> > > Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx> > > Reviewed-by: Curtis Malainey <cujomalainey@xxxxxxxxxxxx> > > Reviewed-by: Tzung-Bi Shih <tzungbi@xxxxxxxxxx> > > Reviewed-by: YC Hung <yc.hung@xxxxxxxxxxxx> > > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx> > > --- > > drivers/firmware/Kconfig | 1 + > > drivers/firmware/Makefile | 1 + > > drivers/firmware/mediatek/Kconfig | 9 + > > drivers/firmware/mediatek/Makefile | 2 + > > drivers/firmware/mediatek/mtk-adsp-ipc.c | 161 ++++++++++++++++++ > > .../linux/firmware/mediatek/mtk-adsp-ipc.h | 65 +++++++ > > 6 files changed, 239 insertions(+) > > create mode 100644 drivers/firmware/mediatek/Kconfig > > create mode 100644 drivers/firmware/mediatek/Makefile > > create mode 100644 drivers/firmware/mediatek/mtk-adsp-ipc.c > > create mode 100644 include/linux/firmware/mediatek/mtk-adsp-ipc.h > > Why do you have a .h file, and export symbols in your .c file, yet you > have no user of these symbols or header file? > > Without a user, we can not take this, sorry. MediaTek have adsp client drivers on 2 chips that use symbols from this module. We were planned to upstream them after Linux community accept this module. I will add those client drivers in next version. > > This should just be one single .c file. > > Also, why a whole subdirectory for just one .c file? Ok, I'll move the souce out and remove this subdirectory in next version. Thank you very much. Best regards, TingHan > > thanks, > > greg k-h
