Re: [PATCH 1/5] soundwire: qcom: return error when pm_runtime_get_sync fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 27/04/2022 00:56, Bard Liao wrote:
From: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>

For some reason there's a missing error return in two places.

Fixes: 74e79da9fd46a ("soundwire: qcom: add runtime pm support")
Fixes: 04d46a7b38375 ("soundwire: qcom: add in-band wake up interrupt support")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@xxxxxxxxxxxxxxx>
Signed-off-by: Bard Liao <yung-chuan.liao@xxxxxxxxxxxxxxx>
---

Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>

  drivers/soundwire/qcom.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
index f5fc8c27012a..c40c25f2d264 100644
--- a/drivers/soundwire/qcom.c
+++ b/drivers/soundwire/qcom.c
@@ -516,6 +516,7 @@ static irqreturn_t qcom_swrm_wake_irq_handler(int irq, void *dev_id)
  				    "pm_runtime_get_sync failed in %s, ret %d\n",
  				    __func__, ret);
  		pm_runtime_put_noidle(swrm->dev);
+		return ret;
  	}
if (swrm->wake_irq > 0) {
@@ -1258,6 +1259,7 @@ static int swrm_reg_show(struct seq_file *s_file, void *data)
  				    "pm_runtime_get_sync failed in %s, ret %d\n",
  				    __func__, ret);
  		pm_runtime_put_noidle(swrm->dev);
+		return ret;
  	}
for (reg = 0; reg <= SWR_MSTR_MAX_REG_ADDR; reg += 4) {



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux