Re: [PATCH] [ALSA] soc - fsl_ssi.c fix "BUG: scheduling while atomic"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 08, 2008 at 02:19:36PM -0500, Timur Tabi wrote:
> Anton Vorontsov wrote:
> 
> > We must not sleep with irqs disabled, so replace msleep with mdelay.
> > 
> > Signed-off-by: Anton Vorontsov <avorontsov@xxxxxxxxxxxxx>
> 
> Acked-By: Timur Tabi <timur@xxxxxxxxxxxxx>
> 
> Anton, can you try testing the code with the call to mdelay/msleep commented
> out?

Ok, I'll try...

> On my quick test, I didn't need it, so I have a suspicion that it was
> needed only for the old 1.0 silicon.

Are there any drawbacks of mdelay'ing? Since some silicons need this
we'd better leave it then.

-- 
Anton Vorontsov
email: cbouatmailru@xxxxxxxxx
irc://irc.freenode.net/bd2
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux