On 4/26/22 12:55 PM, Lad, Prabhakar wrote: [...] >>> Propagate error codes returned from platform_get_irq_byname() instead of >>> returning -ENODEV. platform_get_irq_byname() may return -EPROBE_DEFER, to >>> handle such cases propagate the error codes. >>> >>> While at it drop the dev_err_probe() messages as platform_get_irq_byname() >>> already does this for us in case of error. >>> >>> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> >>> --- >>> v1->v2 >>> * No change >>> --- >>> sound/soc/sh/rz-ssi.c | 9 +++------ >>> 1 file changed, 3 insertions(+), 6 deletions(-) >>> >>> diff --git a/sound/soc/sh/rz-ssi.c b/sound/soc/sh/rz-ssi.c >>> index cec458b8c507..d9a684e71ec3 100644 >>> --- a/sound/soc/sh/rz-ssi.c >>> +++ b/sound/soc/sh/rz-ssi.c >>> @@ -977,8 +977,7 @@ static int rz_ssi_probe(struct platform_device *pdev) >>> /* Error Interrupt */ >>> ssi->irq_int = platform_get_irq_byname(pdev, "int_req"); >>> if (ssi->irq_int < 0) >>> - return dev_err_probe(&pdev->dev, -ENODEV, >>> - "Unable to get SSI int_req IRQ\n"); >>> + return ssi->irq_int; >> >> Why not: >> >> return dev_err_probe(&pdev->dev, ssi->irq_int, >> "Unable to get SSI int_req IRQ\n"); >> > That is because platform_get_irq_byname() already does this for us [0] > (also mentioned in the commit message). In case I keep the > dev_err_probe() I'll get two prints for each error. > > [0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/base/platform.c?h=v5.18-rc4#n471 Ah! Sorry, didn't read your commit log... :-/ More shame on me as it was me who added dev_err_probe() call there! :-) > Cheers, > Prabhakar [...] MBR, Sergey
