Hi Peter, I love your patch! Yet something to improve: [auto build test ERROR on tiwai-sound/for-next] [also build test ERROR on v5.18-rc4 next-20220422] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Peter-Ujfalusi/ALSA-memalloc-Add-fallback-SG-buffer-free-if-fallback-is-used-for-noncontig/20220425-203012 base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next config: arm-randconfig-r033-20220425 (https://download.01.org/0day-ci/archive/20220426/202204260301.TAt89QGn-lkp@xxxxxxxxx/config) compiler: arm-linux-gnueabi-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/bf91cb1cd103c5f1e78fa154c30f1436be2723ac git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Peter-Ujfalusi/ALSA-memalloc-Add-fallback-SG-buffer-free-if-fallback-is-used-for-noncontig/20220425-203012 git checkout bf91cb1cd103c5f1e78fa154c30f1436be2723ac # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash sound/core/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): sound/core/memalloc.c: In function 'snd_dma_noncontig_free': >> sound/core/memalloc.c:540:31: error: 'SNDRV_DMA_TYPE_DEV_WC_SG_FALLBACK' undeclared (first use in this function); did you mean 'SNDRV_DMA_TYPE_DEV_WC_SG'? 540 | if (dmab->dev.type == SNDRV_DMA_TYPE_DEV_WC_SG_FALLBACK || | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | SNDRV_DMA_TYPE_DEV_WC_SG sound/core/memalloc.c:540:31: note: each undeclared identifier is reported only once for each function it appears in >> sound/core/memalloc.c:541:31: error: 'SNDRV_DMA_TYPE_DEV_SG_FALLBACK' undeclared (first use in this function); did you mean 'SNDRV_DMA_TYPE_DEV_SG'? 541 | dmab->dev.type == SNDRV_DMA_TYPE_DEV_SG_FALLBACK) { | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | SNDRV_DMA_TYPE_DEV_SG >> sound/core/memalloc.c:543:17: error: implicit declaration of function 'snd_dma_sg_fallback_free'; did you mean 'snd_dma_vmalloc_free'? [-Werror=implicit-function-declaration] 543 | snd_dma_sg_fallback_free(dmab); | ^~~~~~~~~~~~~~~~~~~~~~~~ | snd_dma_vmalloc_free cc1: some warnings being treated as errors vim +540 sound/core/memalloc.c 537 538 static void snd_dma_noncontig_free(struct snd_dma_buffer *dmab) 539 { > 540 if (dmab->dev.type == SNDRV_DMA_TYPE_DEV_WC_SG_FALLBACK || > 541 dmab->dev.type == SNDRV_DMA_TYPE_DEV_SG_FALLBACK) { 542 /* The allocation is done with a fallback, use the matching free */ > 543 snd_dma_sg_fallback_free(dmab); 544 return; 545 } 546 547 dma_vunmap_noncontiguous(dmab->dev.dev, dmab->area); 548 dma_free_noncontiguous(dmab->dev.dev, dmab->bytes, dmab->private_data, 549 dmab->dev.dir); 550 } 551 -- 0-DAY CI Kernel Test Service https://01.org/lkp
