On 4/22/22 02:38, Amadeusz Sławiński wrote:
> On 4/21/2022 6:26 PM, Pierre-Louis Bossart wrote:
>> Commit a0f84dfb3f6d9 ("ASoC: SOF: IPC: dai: Expand DAI_CONFIG IPC flags")
>> did not update the SOF_ABI_MINOR, bump to version 20 before new
>> changes are added.
>>
>> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
>> Reviewed-by: Daniel Baluta <daniel.baluta@xxxxxxx>
>> Reviewed-by: Kai Vehmanen <kai.vehmanen@xxxxxxxxxxxxxxx>
>> ---
>> include/uapi/sound/sof/abi.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/uapi/sound/sof/abi.h b/include/uapi/sound/sof/abi.h
>> index e052653a6e4cc..42227d4cb92c5 100644
>> --- a/include/uapi/sound/sof/abi.h
>> +++ b/include/uapi/sound/sof/abi.h
>> @@ -26,7 +26,7 @@
>> /* SOF ABI version major, minor and patch numbers */
>> #define SOF_ABI_MAJOR 3
>> -#define SOF_ABI_MINOR 19
>> +#define SOF_ABI_MINOR 20
>> #define SOF_ABI_PATCH 1
>> /* SOF ABI version number. Format within 32bit word is MMmmmppp */
>
> Seeing as you include hash id in commit message it should probably have Fixes tag, so if someone pulls the other commit they know to also back port this one?
No, there's no need for a Fixes tag and backport, this is not really a functional issue.
I added this patch to make a follow-up addition by Mediatek less confusing, in the initial version it came with two increments of the ABI version because of that earlier miss.
see https://github.com/thesofproject/linux/pull/3353 for details.
