On 4/20/22 10:23, Mark Brown wrote: > On Wed, Apr 20, 2022 at 08:28:31AM -0500, Pierre-Louis Bossart wrote: >> On 4/19/22 22:03, cgel.zte@xxxxxxxxx wrote: >>> From: Minghao Chi <chi.minghao@xxxxxxxxxx> > >>> Using pm_runtime_resume_and_get() to replace pm_runtime_get_sync and >>> pm_runtime_put_noidle. This change is just to simplify the code, no >>> actual functional changes. > >> Well, maybe that's a simplification, but we've been using the same pattern for years now. > >> Is there really a clear direction to use this new function? > > It seems like a much better pattern and there's been a steady stream of > conversion patches. The whole get/idle thing is pretty much just sharp > edges. > >> the overwhelming majority of drivers in sound/soc still rely on the pm_runtime_get_sync (111 v. 7). > > We'll get there I'm sure. ok, I'll send follow-up patches for the remaining code. For this patch: Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>