Re: [PATCH] ALSA: hda/i915: Fix one too many pci_dev_put()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 19, 2022 at 09:01:34AM +0200, Takashi Iwai wrote:
On Sat, 16 Apr 2022 08:44:18 +0200,
Lucas De Marchi wrote:

pci_get_class() will already unref the pci device passed as argument.
So if it's unconditionally unref'ed, even if the loop is not stopped,
there will be one too many unref for each device not matched.

Cc: Kai Vehmanen <kai.vehmanen@xxxxxxxxxxxxxxx>
Cc: Takashi Iwai <tiwai@xxxxxxx>
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5701
Fixes: 0dc2696a4623 ("ALSA: hda/i915 - skip acomp init if no matching display")
Signed-off-by: Lucas De Marchi <lucas.demarchi@xxxxxxxxx>

Thanks, applied now.
But the Fixes commit id was wrong.  I corrected to the right upstream
one, c9db8a30d9f0.

indeed, I messed that up, using the hash from our local tree.

thanks
Lucas De Marchi



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux