On 16 April 2022 13:53, Mark Brown wrote: > mutex_lock(&da7219->ctrl_lock); > - ret = regmap_raw_write(da7219->regmap, reg, &val, sizeof(val)); > + ret = regmap_raw_read(da7219->regmap, reg, &val_old, > sizeof(val_old)); > + if (ret != 0) I think you may have intended to confirm success here > + ret = regmap_raw_write(da7219->regmap, reg, > + &val_new, sizeof(val_new)); > mutex_unlock(&da7219->ctrl_lock);