Re: [PATCH v2] ALSA: jack: Access input_dev under mutex

Cezary Rojewski <cezary.rojewski@xxxxxxxxx> · Tue, 12 Apr 2022 12:07:29 +0200

On 2022-04-12 11:44 AM, Takashi Iwai wrote:
On Tue, 12 Apr 2022 11:16:28 +0200,
Amadeusz Sławiński wrote:

It is possible when using ASoC that input_dev is unregistered while
calling snd_jack_report, which causes NULL pointer dereference.
In order to prevent this serialize access to input_dev using mutex lock.

Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@xxxxxxxxxxxxxxx>
---

Changes:
v2:
  - drop mutex in snd_jack_new
  - add comment that snd_jack_report() should be called in context where
    it can sleep

Thanks, applied now.

If you would be needing a reviewed-by-tag, you can safely apply my (it's 
missing in v2 sent by Amadeo).

For transparency:

Reviewed-by: Cezary Rojewski <cezary.rojewski@xxxxxxxxx>

Regards,
Czarek