On Tue, 5 Apr 2022 20:10:38 +0800, Zheyu Ma wrote: > When the driver fails during probing, the driver should disable the > regulator, not just handle it in wm8731_hw_init(). > > The following log reveals it: > > [ 17.812483] WARNING: CPU: 1 PID: 364 at drivers/regulator/core.c:2257 _regulator_put+0x3ec/0x4e0 > [ 17.815958] RIP: 0010:_regulator_put+0x3ec/0x4e0 > [ 17.824467] Call Trace: > [ 17.824774] <TASK> > [ 17.825040] regulator_bulk_free+0x82/0xe0 > [ 17.825514] devres_release_group+0x319/0x3d0 > [ 17.825882] i2c_device_probe+0x766/0x940 > [ 17.829198] i2c_register_driver+0xb5/0x130 > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: wm8731: Disable the regulator when probing fails commit: 92ccbf17eeacf510cf1eed9c252d9332ca24f02d All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
