Re: [PATCH v4 21/21] ASoC: fsl_micfil: Remove debug message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 08, 2022 at 01:21:41PM +0800, Shengjiu Wang wrote:
>    On Thu, Apr 7, 2022 at 4:49 PM Sascha Hauer <[1]s.hauer@xxxxxxxxxxxxxx>
>    wrote:
> 
>      The micfil driver prints out the IRQ numbers for each interrupt at error
>      level. This information is useful for debugging at best, remove it.
> 
>      Signed-off-by: Sascha Hauer <[2]s.hauer@xxxxxxxxxxxxxx>
>      ---
> 
>      Notes:
>          Changes since v3:
>          - new patch
> 
>       sound/soc/fsl/fsl_micfil.c | 1 -
>       1 file changed, 1 deletion(-)
> 
>      diff --git a/sound/soc/fsl/fsl_micfil.c b/sound/soc/fsl/fsl_micfil.c
>      index 8f0ab61fd1b07..be669523a4bf7 100644
>      --- a/sound/soc/fsl/fsl_micfil.c
>      +++ b/sound/soc/fsl/fsl_micfil.c
>      @@ -597,7 +597,6 @@ static int fsl_micfil_probe(struct platform_device
>      *pdev)
>              /* get IRQs */
>              for (i = 0; i < MICFIL_IRQ_LINES; i++) {
>                      micfil->irq[i] = platform_get_irq(pdev, i);
>      -               dev_err(&pdev->dev, "GET IRQ: %d\n", micfil->irq[i]);
> 
>    dev_err to dev_dbg, is it better?

I don't think so. You can see the interrupts in /proc/interrupts and
currently the interrupts are not even used in the driver.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux