Re: [PATCH 10/14] ASoC: Intel: avs: Path creation and freeing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Cezary,

I love your patch! Perhaps something to improve:

[auto build test WARNING on broonie-sound/for-next]
[also build test WARNING on tiwai-sound/for-next next-20220328]
[cannot apply to v5.17]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Cezary-Rojewski/ASoC-Intel-avs-Topology-and-path-management/20220329-012230
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20220329/202203290516.fzAxfExg-lkp@xxxxxxxxx/config)
compiler: aarch64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/cd5b9e82ba0830b3e2874f6b88054cf8c09c977d
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Cezary-Rojewski/ASoC-Intel-avs-Topology-and-path-management/20220329-012230
        git checkout cd5b9e82ba0830b3e2874f6b88054cf8c09c977d
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm64 SHELL=/bin/bash sound/soc/intel/avs/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

   sound/soc/intel/avs/path.c: In function 'avs_path_create_unlocked':
>> sound/soc/intel/avs/path.c:232:35: warning: variable 'acomp' set but not used [-Wunused-but-set-variable]
     232 |         struct avs_soc_component *acomp;
         |                                   ^~~~~


vim +/acomp +232 sound/soc/intel/avs/path.c

   228	
   229	static struct avs_path *avs_path_create_unlocked(struct avs_dev *adev, u32 dma_id,
   230							 struct avs_tplg_path *template)
   231	{
 > 232		struct avs_soc_component *acomp;
   233		struct avs_path *path;
   234		int ret;
   235	
   236		acomp = to_avs_soc_component(template->owner->owner->comp);
   237	
   238		path = kzalloc(sizeof(*path), GFP_KERNEL);
   239		if (!path)
   240			return ERR_PTR(-ENOMEM);
   241	
   242		ret = avs_path_init(adev, path, template, dma_id);
   243		if (ret < 0)
   244			goto err;
   245	
   246		path->state = AVS_PPL_STATE_INVALID;
   247		return path;
   248	err:
   249		avs_path_free_unlocked(path);
   250		return ERR_PTR(ret);
   251	}
   252	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux