> -----Original Message----- > From: Steve Lee <steve.lee.analog@xxxxxxxxx> > Sent: Monday, March 28, 2022 4:12 AM > To: lgirdwood@xxxxxxxxx; broonie@xxxxxxxxxx; perex@xxxxxxxx; > tiwai@xxxxxxxx; ryans.lee@xxxxxxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; alsa-devel@xxxxxxxxxxxxxxxx > Cc: krzk@xxxxxxxxxx; Sa, Nuno <Nuno.Sa@xxxxxxxxxx>; Steve Lee > <steve.lee.analog@xxxxxxxxx> > Subject: [V3 1/2] ASoC: max98390: Add reset gpio control > > [External] > > Add reset gpio control to support RESET PIN connected to gpio. > > Signed-off-by: Steve Lee <steve.lee.analog@xxxxxxxxx> > --- > sound/soc/codecs/max98390.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/sound/soc/codecs/max98390.c > b/sound/soc/codecs/max98390.c > index 40fd6f363f35..05df9b85d9b0 100644 > --- a/sound/soc/codecs/max98390.c > +++ b/sound/soc/codecs/max98390.c > @@ -1022,6 +1022,7 @@ static int max98390_i2c_probe(struct > i2c_client *i2c, > > struct max98390_priv *max98390 = NULL; > struct i2c_adapter *adapter = i2c->adapter; > + struct gpio_desc *reset_gpio; > > ret = i2c_check_functionality(adapter, > I2C_FUNC_SMBUS_BYTE > @@ -1073,6 +1074,17 @@ static int max98390_i2c_probe(struct > i2c_client *i2c, > return ret; > } > > + reset_gpio = devm_gpiod_get_optional(&i2c->dev, > + "reset", GPIOD_OUT_LOW); Forgot to mention, As you stated in the bindings the gpio is active low, this should also be GPIOD_OUT_HIGH, if we want to have the device in reset after this call. - Nuno Sá
