Hi > > This series has a bunch of cleanups for the FSL MICFIL driver. There is not > much chance for regressions in this series as the driver currently can't work > at all. The MICFIL needs multififo support in the i.MX SDMA engine which is > added with this series, see 10/19. > > The multififo support is selected in the dma phandle arguments in the device > tree, the transfer type must be '25' aka IMX_DMATYPE_MULTI_SAI. > This is set already to 25 in the upstream i.MX8M[NM] dtsi files, but the SDMA > driver silently ignores unsupported values instead of throwing an error. This > is fixed in this series and multififo support is added. > > I think the series should go via the ASoC tree, so I'll need an ack from the > DMA guys for 9/19 and 10/10. Thanks for this series, basically I am ok with the fsl_micfil part, just a comments for sdma change as we have discussed. Best regards Wang Shengjiu > > Sascha > > Sascha Hauer (19): > ASoC: fsl_micfil: Drop unnecessary register read > ASoC: fsl_micfil: Drop unused register read > ASoC: fsl_micfil: drop fsl_micfil_set_mclk_rate() > ASoC: fsl_micfil: do not define SHIFT/MASK for single bits > ASoC: fsl_micfil: use GENMASK to define register bit fields > ASoC: fsl_micfil: use clear/set bits > ASoC: fsl_micfil: drop error messages from failed register accesses > ASoC: fsl_micfil: drop unused variables > dma: imx-sdma: error out on unsupported transfer types > dma: imx-sdma: Add multi fifo support > ASoC: fsl_micfil: add multi fifo support > ASoC: fsl_micfil: use define for OSR default value > ASoC: fsl_micfil: Drop get_pdm_clk() > ASoC: fsl_micfil: simplify clock setting > ASoC: fsl_micfil: rework quality setting > ASoC: fsl_micfil: drop unused include > ASoC: fsl_micfil: drop only once used defines > ASoC: fsl_micfil: drop support for undocumented property > ASoC: fsl_micfil: fold fsl_set_clock_params() into its only user > > drivers/dma/imx-sdma.c | 71 ++++- > include/linux/platform_data/dma-imx.h | 7 + > sound/soc/fsl/fsl_micfil.c | 368 +++++++++----------------- > sound/soc/fsl/fsl_micfil.h | 269 +++++-------------- > 4 files changed, 265 insertions(+), 450 deletions(-) > > -- > 2.30.2
