On Wed, Mar 23, 2022 at 10:56:04AM +0100, Amadeusz Sławiński wrote: > this would be probably overdoing it, 4 patches should be enough. > Patch 1 and 3 seem ok to me, I would just split patch 2, and reorder a bit, > so something like: > 1. [PATCH v4 1/3] rename tas2764 to tas27xx-Makefile and Kconfig > 2. here patch renaming variables (2764 -> xxxx) > 3. [PATCH v4 3/3] update tas27xx.h to support either TAS2764 or TAS2780 > 4. here patch adding TAS2780 support That looks like a good plan. > The reason why patch 3, should go before one adding support is that there is > dependency on information present in header, and you don't want to break > build when someone does git bisect with your driver enabled. Indeed I test for this when applying patches.
Attachment:
signature.asc
Description: PGP signature
