On Mon, Mar 21, 2022 at 05:14:08PM +0800, Jiaxin Yu wrote:
> On Mon, 2022-03-21 at 11:59 +0800, Tzung-Bi Shih wrote:
> > On Sat, Mar 19, 2022 at 07:41:10PM +0800, Jiaxin Yu wrote:
> > > @@ -1145,6 +1140,13 @@ static int mt8192_mt6359_dev_probe(struct
> > > platform_device *pdev)
> > > goto err_speaker_codec;
> > > }
> > >
> > > + headset_codec = of_get_child_by_name(pdev->dev.of_node,
> > > "mediatek,headset-codec");
> > > + if (!headset_codec) {
> > > + ret = -EINVAL;
> > > + dev_err_probe(&pdev->dev, ret, "Property
> > > 'headset_codec' missing or invalid\n");
> > > + goto err_headset_codec;
> > > + }
> >
> > (to be neat) Does it have any reason to prevent from using
> > of_parse_phandle()
> > but of_get_child_by_name()?
>
> "mediatek,headset-codec" is a child node of pdev->dev.of_node, so I use
> of_get_child_by_name() to get and pass it to
> snd_soc_of_get_dai_link_codecs().
"mediatek,platform" and "mediatek,hdmi-codec" are also children of
pdev->dev.of_node. I guess my question is: why doesn't it also use
of_parse_phandle() for "mediatek,headset-codec"? Did I misunderstand?
