On Fri, 18 Mar 2022 16:55:46 +0100, Vitaly Rodionov wrote: > > This series adds new HW variants for Dell's Dolphin and Warlock, > and also fixies few very minor issues. > > Stefan Binding (5): > ALSA: hda/cs8409: Fix Warlock using dual mic configuration > ALSA: hda/cs8409: Re-order quirk table into ascending order > ALSA: hda/cs8409: Fix Full Scale Volume setting for all variants > ALSA: hda/cs8409: Support new Warlock MLK Variants > ALSA: hda/cs8409: Disable HSBIAS_SENSE_EN for Cyborg > > Vitaly Rodionov (1): > ALSA: hda/cs8409: Add new Dolphin HW variants The code changes look OK through a quick glance, but those patches lack of the proper patch descriptions completely. For example, the patch 1 says "ALSA: hda/cs8409: Fix Warlock using dual mic configuration" in the subject, and that's all. Fix what for Warlock model? Why the dual mic configuration makes things better, if any? A few other patches have the same problem: it's not clear *why* the changes are done. Please give a bit more description. Also, the patch 4 introduces the code with a wrong indentation, which is corrected in a later patch. That confuses readers, too. Better to fix in the first place. Could you update those and resubmit? thanks, Takashi
