Re: [PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP machine with alc671

["huangwenhui" <huangwenhuia@xxxxxxxxxxxxx>]

I will modify the patch and commit again.


Thanks.
 
 
------------------ Original ------------------
From: &nbsp;"Takashi&nbsp;Iwai"<tiwai@xxxxxxx&gt;;
Date: &nbsp;Fri, Mar 11, 2022 04:30 PM
To: &nbsp;"huangwenhui"<huangwenhuia@xxxxxxxxxxxxx&gt;; 
Cc: &nbsp;"perex"<perex@xxxxxxxx&gt;; "tiwai"<tiwai@xxxxxxxx&gt;; "jeremy.szu"<jeremy.szu@xxxxxxxxxxxxx&gt;; "hui.wang"<hui.wang@xxxxxxxxxxxxx&gt;; "wse"<wse@xxxxxxxxxxxxxxxxxxx&gt;; "cam"<cam@xxxxxxxxxxx&gt;; "kailang"<kailang@xxxxxxxxxxx&gt;; "tanureal"<tanureal@xxxxxxxxxxxxxxxxxxxxx&gt;; "sami"<sami@xxxxxxxx&gt;; "alsa-devel"<alsa-devel@xxxxxxxxxxxxxxxx&gt;; "linux-kernel"<linux-kernel@xxxxxxxxxxxxxxx&gt;; 
Subject: &nbsp;Re: [PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP machine with alc671

&nbsp;

On Fri, 11 Mar 2022 02:20:42 +0100,
huangwenhui wrote:
&gt; 
&gt; Hi&nbsp; Takashi,
&gt; 
&gt; if adjusting the mixer element or replugging the headset, the headphone would
&gt; be unmuted.
&gt; But most users hope that the default state is unmuted.
&gt; Should this unconditional unmute be required?

It's the standard behavior for most of ALSA drivers.

The initial mute state is rather controlled via alsactl, restoring the
previous state.&nbsp; Also, the sound server like PulseAudio or pipewire
does unmute automatically.&nbsp; If this doesn't work as expected, that's a
more problem to diagnose.


Takashi

&gt; 
&gt; Thanks.
&gt; 
&gt; ------------------ Original ------------------
&gt; From:&nbsp; "Takashi Iwai"<tiwai@xxxxxxx&gt;;
&gt; Date:&nbsp; Thu, Mar 10, 2022 10:03 PM
&gt; To:&nbsp; "huangwenhui"<huangwenhuia@xxxxxxxxxxxxx&gt;;
&gt; Cc:&nbsp; "perex"<perex@xxxxxxxx&gt;; "tiwai"<tiwai@xxxxxxxx&gt;; "jeremy.szu"
&gt; <jeremy.szu@xxxxxxxxxxxxx&gt;; "hui.wang"<hui.wang@xxxxxxxxxxxxx&gt;; "wse"
&gt; <wse@xxxxxxxxxxxxxxxxxxx&gt;; "cam"<cam@xxxxxxxxxxx&gt;; "kailang"
&gt; <kailang@xxxxxxxxxxx&gt;; "tanureal"<tanureal@xxxxxxxxxxxxxxxxxxxxx&gt;; "sami"
&gt; <sami@xxxxxxxx&gt;; "alsa-devel"<alsa-devel@xxxxxxxxxxxxxxxx&gt;; "linux-kernel"
&gt; <linux-kernel@xxxxxxxxxxxxxxx&gt;;
&gt; Subject:&nbsp; Re: [PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP
&gt; machine with alc671
&gt;&nbsp; 
&gt; On Thu, 10 Mar 2022 14:58:36 +0100,
&gt; huangwenhui wrote:
&gt; &gt;
&gt; &gt; Hi&nbsp; Takashi,
&gt; &gt;
&gt; &gt; Thank you for your reply.
&gt; &gt;
&gt; &gt; When booting with plugged headset, the headphone will be muted.
&gt; 
&gt; The muted state is the default behavior.&nbsp; Wouldn't it be unmuted if
&gt; you adjust the corresponding mixer element?
&gt; 
&gt; Takashi
&gt; 
&gt; &gt;
&gt; &gt; Thanks.
&gt; &gt; 
&gt; &gt; ------------------ Original ------------------
&gt; &gt; From:&nbsp; "Takashi Iwai"<tiwai@xxxxxxx&gt;;
&gt; &gt; Date:&nbsp; Thu, Mar 10, 2022 09:29 PM
&gt; &gt; To:&nbsp; "huangwenhui"<huangwenhuia@xxxxxxxxxxxxx&gt;;
&gt; &gt; Cc:&nbsp; "perex"<perex@xxxxxxxx&gt;; "tiwai"<tiwai@xxxxxxxx&gt;; "jeremy.szu"
&gt; &gt; <jeremy.szu@xxxxxxxxxxxxx&gt;; "hui.wang"<hui.wang@xxxxxxxxxxxxx&gt;; "wse"
&gt; &gt; <wse@xxxxxxxxxxxxxxxxxxx&gt;; "cam"<cam@xxxxxxxxxxx&gt;; "kailang"
&gt; &gt; <kailang@xxxxxxxxxxx&gt;; "tanureal"<tanureal@xxxxxxxxxxxxxxxxxxxxx&gt;; "sami"
&gt; &gt; <sami@xxxxxxxx&gt;; "alsa-devel"<alsa-devel@xxxxxxxxxxxxxxxx&gt;; "linux-kernel"
&gt; &gt; <linux-kernel@xxxxxxxxxxxxxxx&gt;;
&gt; &gt; Subject:&nbsp; Re: [PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP
&gt; &gt; machine with alc671
&gt; &gt; 
&gt; &gt; On Thu, 10 Mar 2022 14:03:01 +0100,
&gt; &gt; huangwenhui wrote:
&gt; &gt; &gt;
&gt; &gt; &gt; On a HP 288 Pro G8, the front Mic could not be detected.
&gt; &gt; &gt;
&gt; &gt; &gt; Signed-off-by: huangwenhui <huangwenhuia@xxxxxxxxxxxxx&gt;
&gt; &gt;
&gt; &gt; Thanks for the patch.&nbsp; Most of the changes look OK, but one thing I
&gt; &gt; still don't get:
&gt; &gt;
&gt; &gt; &gt; + case HDA_FIXUP_ACT_INIT:
&gt; &gt; &gt; + alc_write_coef_idx(codec, 0x19, 0xa054);
&gt; &gt; &gt; + msleep(80);
&gt; &gt; &gt; + snd_hda_codec_write(codec, hp_pin, 0,
&gt; &gt; &gt; +&nbsp;&nbsp;&nbsp;&nbsp; AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_UNMUTE);
&gt; &gt;
&gt; &gt; Why this unconditional unmute is required for fixing the mic problem?
&gt; &gt;
&gt; &gt; Takashi
&gt; &gt;
&gt; &gt;
&gt; 
&gt;