Takashi Iwai wrote: > At Fri, 25 Apr 2008 09:06:19 +0200, > Pavel Hofman wrote: >> Takashi Iwai wrote: >>>> I do not know the reason for MPU401_INFO_NO_ACK. You removed it from the >>>> original patch, but without it I always get the input/output error. >>> Ah, thanks, I overlooked it. >>> Fixed now. >> Takashi, thanks, but the patch I sent you sets MPU401_INFO_INPUT and >> MPU401_INFO_OUTPUT flags too. They enable the actual input/output >> methods in mpu401_uart.c. > > They aren't needed if you create full-duplex streams. > Could you check whether the latest code still causes any errors? Oh, I overlooked the code if (! (info_flags & (MPU401_INFO_INPUT | MPU401_INFO_OUTPUT))) info_flags |= MPU401_INFO_INPUT | MPU401_INFO_OUTPUT; in snd_mpu401_uart_new. So it should be OK. I will test and report errors, but I don't expect any :) Thanks, Pavel. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
