On 3/8/22 12:23, Pierre-Louis Bossart wrote:
> on x86_64:
>
> ERROR: modpost: "sof_dai_get_bclk"
> [sound/soc/intel/boards/snd-soc-intel-sof-cirrus-common.ko] undefined!
>
> ERROR: modpost: "sof_dai_get_mclk"
> [sound/soc/intel/boards/snd-soc-intel-sof-realtek-common.ko]
> undefined!
>
> This comes from a missing dependency on at least ONE SOF platform
> being selected. This dependency exists for all other machine drivers,
> this was missed in the earlier reviews.
>
> Fixes: 2fe14ff61bd6 ("ASoC: Intel: sof_ssp_amp: rename driver and support cs35l41 amplifier")
> Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Tested-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Thanks.
> ---
> sound/soc/intel/boards/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/sound/soc/intel/boards/Kconfig b/sound/soc/intel/boards/Kconfig
> index a62785893bec..f3873b5bea87 100644
> --- a/sound/soc/intel/boards/Kconfig
> +++ b/sound/soc/intel/boards/Kconfig
> @@ -616,6 +616,8 @@ config SND_SOC_INTEL_SOF_DA7219_MAX98373_MACH
>
> endif ## SND_SOC_SOF_JASPERLAKE
>
> +if SND_SOC_SOF_HDA_LINK
> +
> config SND_SOC_INTEL_SOF_SSP_AMP_MACH
> tristate "SOF with amplifiers in I2S Mode"
> depends on I2C && ACPI
> @@ -632,6 +634,7 @@ config SND_SOC_INTEL_SOF_SSP_AMP_MACH
> with RT1308/CS35L41 I2S audio codec.
> Say Y if you have such a device.
> If unsure select "N".
> +endif ## SND_SOC_SOF_HDA_LINK
>
> if SND_SOC_SOF_ELKHARTLAKE
>
--
~Randy
