Re: [PATCH 7/8] ASoC: Intel: sof_ssp_amp: rename driver and support cs35l41 amplifier

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 3/2/22 8:56 AM, Amadeusz Sławiński wrote:
On 3/1/2022 8:49 PM, Pierre-Louis Bossart wrote:
From: Brent Lu <brent.lu@xxxxxxxxx>

Add support of CS35L41 amplifier to the machine driver, as well as
the support of HDMI playback and BT offload DAI Link.

Rename the driver to a generic name to support different amplifiers
from different vendors.

Reviewed-by: Bard Liao <yung-chuan.liao@xxxxxxxxxxxxxxx>
Signed-off-by: Brent Lu <brent.lu@xxxxxxxxx>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
---

Eh... rename should happen in separate patch, as there seems to be some changes done to the file and it is quite hard to review it, when whole file is in diff due to being moved.

that was a conscious decision on my side to keep the patches as is, first add the initial contribution for the rt1308 amp from our embedded Linux team, and show how it was extended to support another amplifier for Chrome.

Indeed it leads to a bit of a tick-tock patch with the rename but it's not that bad, is it? The alternative would lead to a much bigger patch if I squash the whole thing.



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux