回复:[PATCH -next] ASoC: amd: Fix an ignored error return from platform_get_irq_byname()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The function dev_err_probe() is called in function platform_get_irq_byname() to print the error code.
------------------------------------------------------------------
发件人:Mark Brown <broonie@xxxxxxxxxx>
发送时间:2022年3月1日(星期二) 20:40
收件人:Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>
抄 送:lgirdwood <lgirdwood@xxxxxxxxx>; perex <perex@xxxxxxxx>; tiwai <tiwai@xxxxxxxx>; tangmeng <tangmeng@xxxxxxxxxxxxx>; alsa-devel <alsa-devel@xxxxxxxxxxxxxxxx>; linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>; Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
主 题:Re: [PATCH -next] ASoC: amd: Fix an ignored error return from platform_get_irq_byname()

On Tue, Mar 01, 2022 at 02:49:20PM +0800, Yang Li wrote:

> - adata->i2s_irq = platform_get_irq_byname(pdev, "acp_dai_irq");
> - if (adata->i2s_irq < 0)
> + adata->i2s_irq = ret = platform_get_irq_byname(pdev, "acp_dai_irq");
> + if (ret < 0)
>    return -ENODEV;

If an error code is being returned we should report that error code
rather than squashing it down to -ENODEV.





[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux