On Tue, Mar 01, 2022 at 02:54:06PM +0100, Stephan Gerhold wrote: > On Tue, Mar 01, 2022 at 01:36:33PM +0000, Mark Brown wrote: > > On Tue, Mar 01, 2022 at 01:37:41PM +0100, Stephan Gerhold wrote: > > > + awinic,mode: > > > + description: Amplifier mode (number of pulses for one-wire pulse control) > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > + minimum: 1 > > No maximum? > I wasn't sure if we really want to maintain maxima for several different > Awinic part numbers here. For the AW8738 the maximum is 7, for the > AW87318 (note the additional 1 in the name) it would be 10. The driver > part would be identical for both. > ... But it's probably cleaner to have the schema check for the real > maximum of the selected compatible. I will add a "maximum" in v2. Even if it's just a maximum for any of the supported chips it'd still be something. > > > + sound-name-prefix: true > > While it's very likely that someone will want to use this it shouldn't > > be *mandatory* that they do so, there may be no other controls for it to > > collide with (eg, if none of the other components in the audio path have > > controls). > This line just enables the "sound-name-prefix" from the included > name-prefix.yaml. It's not listed in "required" so it's actually > already optional. Of, that's a really confusing way of importing things.
Attachment:
signature.asc
Description: PGP signature
